Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add maintainer #4234

Merged
merged 2 commits into from
Jul 11, 2023

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Jul 11, 2023

Description

Extract packages there is no TIER IV internal maintainer by following command.

find ./ -name "package.xml" | xargs grep -L "maintainer.*@tier4.jp"

Tests performed

Nothing.

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@github-actions github-actions bot added component:planning Route planning, decision-making, and navigation. (auto-assigned) component:tools Utility and debugging software. (auto-assigned) component:common Common packages from the autoware-common repository. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) labels Jul 11, 2023
Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I can take this part if you want

evaluator/localization_evaluator/package.xml Outdated Show resolved Hide resolved
Co-authored-by: kminoda <44218668+kminoda@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02 🎉

Comparison is base (0795882) 14.21% compared to head (cb518f4) 14.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4234      +/-   ##
==========================================
+ Coverage   14.21%   14.23%   +0.02%     
==========================================
  Files        1597     1597              
  Lines      109806   109842      +36     
  Branches    31487    31504      +17     
==========================================
+ Hits        15605    15635      +30     
  Misses      77255    77255              
- Partials    16946    16952       +6     
Flag Coverage Δ *Carryforward flag
differential 19.70% <0.00%> (?)
total 14.23% <ø> (+0.01%) ⬆️ Carriedforward from 0795882

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
control/shift_decider/src/shift_decider.cpp 0.00% <ø> (ø)
...nner/utils/lane_change/lane_change_module_data.hpp 0.00% <0.00%> (ø)
...nner/include/behavior_path_planner/utils/utils.hpp 45.45% <ø> (ø)
...th_planner/src/scene_module/lane_change/normal.cpp 5.51% <0.00%> (ø)
...avior_path_planner/src/utils/lane_change/utils.cpp 0.36% <0.00%> (-0.05%) ⬇️
...g/behavior_path_planner/src/utils/safety_check.cpp 37.03% <0.00%> (+7.18%) ⬆️
planning/behavior_path_planner/src/utils/utils.cpp 16.18% <0.00%> (+0.66%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mitsudome-r mitsudome-r merged commit 3a22fc7 into autowarefoundation:main Jul 11, 2023
@satoshi-ota satoshi-ota deleted the chore/add-maintainer branch July 11, 2023 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:evaluator Evaluation tools for planning, localization etc. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:tools Utility and debugging software. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants