Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): fix lane change path inside check #4215

Merged

Conversation

rej55
Copy link
Contributor

@rej55 rej55 commented Jul 10, 2023

Description

Before this change, the lane change path is often out of preferred lane because it checks lane change terminal point only.
To fix it, I changed from checking the terminal point to checking the start point.

Related links

Tests performed

Tested in planning simulator

TIER IV INTERNAL TEST

Notes for reviewers

Interface changes

Nothing.

Effects on system behavior

Lane change path will start from non-preferred lane

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 10, 2023
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (0795882) 14.20% compared to head (7a10244) 14.20%.

❗ Current head 7a10244 differs from pull request most recent head 7df165b. Consider uploading reports for the commit 7df165b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4215      +/-   ##
==========================================
- Coverage   14.20%   14.20%   -0.01%     
==========================================
  Files        1597     1597              
  Lines      109806   109816      +10     
  Branches    31487    31494       +7     
==========================================
  Hits        15603    15603              
- Misses      77256    77266      +10     
  Partials    16947    16947              
Flag Coverage Δ *Carryforward flag
differential 13.67% <0.00%> (?)
total 14.20% <ø> (+<0.01%) ⬆️ Carriedforward from 0795882

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...th_planner/src/scene_module/lane_change/normal.cpp 5.49% <0.00%> (-0.02%) ⬇️
...avior_path_planner/src/utils/lane_change/utils.cpp 0.39% <0.00%> (-0.01%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
@rej55 rej55 enabled auto-merge (squash) July 11, 2023 04:08
@rej55 rej55 merged commit 563190f into autowarefoundation:main Jul 11, 2023
rej55 added a commit to tier4/autoware.universe that referenced this pull request Jul 12, 2023
…refoundation#4215)

* fix(behavior_path_planner): fix lane change path inside check

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

* fix(behavior_path_planner): remove unused variable

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

---------

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants