Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(obstacle_avoidance_planner): replace rear and front circle_radius_rate #4204

Conversation

beyzanurkaya
Copy link
Contributor

@beyzanurkaya beyzanurkaya commented Jul 7, 2023

Description

fixes: #4230
vehicle_circles_bicycle_model_front_radius_ratio and vehicle_circles_bicycle_model_rear_radius_ratio are given to calcVehicleCirclesByBicycleModel function in the wrong order.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: beyza <bnk@leodrive.ai>
@beyzanurkaya beyzanurkaya self-assigned this Jul 7, 2023
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 7, 2023
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Patch coverage: 1.75% and project coverage change: +0.91 🎉

Comparison is base (db72d84) 14.26% compared to head (308820b) 15.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4204      +/-   ##
==========================================
+ Coverage   14.26%   15.17%   +0.91%     
==========================================
  Files        1580     1476     -104     
  Lines      108782   102231    -6551     
  Branches    31437    31442       +5     
==========================================
+ Hits        15513    15516       +3     
+ Misses      76394    69825    -6569     
- Partials    16875    16890      +15     
Flag Coverage Δ *Carryforward flag
differential 40.61% <0.00%> (?)
total 15.17% <1.76%> (+0.91%) ⬆️ Carriedforward from 3b0671a

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...sed_occupancy_grid_map/occupancy_grid_map_base.cpp 0.00% <0.00%> (ø)
...ed_occupancy_grid_map/occupancy_grid_map_fixed.cpp 0.00% <0.00%> (ø)
...cupancy_grid_map/occupancy_grid_map_projective.cpp 0.00% <0.00%> (ø)
...d_map/pointcloud_based_occupancy_grid_map_node.cpp 0.00% <0.00%> (ø)
...ic_parallel_parking/geometric_parallel_parking.hpp 20.00% <ø> (ø)
.../scene_module/goal_planner/goal_planner_module.cpp 5.96% <0.00%> (-0.03%) ⬇️
...th_planner/src/scene_module/lane_change/normal.cpp 4.89% <0.00%> (ø)
...rivable_area_expansion/drivable_area_expansion.cpp 50.00% <0.00%> (-1.86%) ⬇️
...er/src/utils/drivable_area_expansion/expansion.cpp 32.40% <0.00%> (+3.09%) ⬆️
...ic_parallel_parking/geometric_parallel_parking.cpp 0.00% <0.00%> (ø)
... and 7 more

... and 108 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@mehmetdogru mehmetdogru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mehmetdogru
Copy link
Contributor

@takayuki5168 could you take a look at this small fix PR?

Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@beyzanurkaya beyzanurkaya merged commit f7f1804 into autowarefoundation:main Jul 11, 2023
@beyzanurkaya beyzanurkaya deleted the fix/vehicle-circles-are-opposite branch July 12, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bicycle model circle radius in the wrong order
3 participants