-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(behavior_path_planner): make use of the avoid_linestring.distance parameter #4198
fix(behavior_path_planner): make use of the avoid_linestring.distance parameter #4198
Conversation
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
This reverts commit 484d9e7.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4198 +/- ##
==========================================
- Coverage 14.80% 14.33% -0.48%
==========================================
Files 1527 1585 +58
Lines 105594 114652 +9058
Branches 32065 35640 +3575
==========================================
+ Hits 15636 16431 +795
- Misses 72887 80580 +7693
- Partials 17071 17641 +570
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
… parameter (autowarefoundation#4198) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
… parameter (autowarefoundation#4198) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
… parameter (autowarefoundation#4198) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
… parameter (autowarefoundation#4198) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
… parameter (autowarefoundation#4198) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
… parameter (autowarefoundation#4198) Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Description
The
avoid_linestring.distance
parameter allows to set a distance to keep between the expanded drivable area and the linestrings to avoid (e.g.,road_border
).This parameter was not used in the code and the functionality was not working properly. This PR fixes this.
Tests performed
Tested in Psim.
Effects on system behavior
Extra distance can be added between the expanded drivable area and the linestrings to avoid.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.