Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): make use of the avoid_linestring.distance parameter #4198

Conversation

maxime-clem
Copy link
Contributor

@maxime-clem maxime-clem commented Jul 7, 2023

Description

The avoid_linestring.distance parameter allows to set a distance to keep between the expanded drivable area and the linestrings to avoid (e.g., road_border).
This parameter was not used in the code and the functionality was not working properly. This PR fixes this.

Tests performed

Tested in Psim.

Effects on system behavior

Extra distance can be added between the expanded drivable area and the linestrings to avoid.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 7, 2023
Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxime-clem maxime-clem added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch coverage: 4.68% and project coverage change: -0.48% ⚠️

Comparison is base (0dae23f) 14.80% compared to head (9c4300c) 14.33%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4198      +/-   ##
==========================================
- Coverage   14.80%   14.33%   -0.48%     
==========================================
  Files        1527     1585      +58     
  Lines      105594   114652    +9058     
  Branches    32065    35640    +3575     
==========================================
+ Hits        15636    16431     +795     
- Misses      72887    80580    +7693     
- Partials    17071    17641     +570     
Flag Coverage Δ *Carryforward flag
differential 13.07% <0.00%> (?)
total 14.29% <9.52%> (-0.52%) ⬇️ Carriedforward from 7e32b12

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ule/dynamic_avoidance/dynamic_avoidance_module.hpp 0.00% <0.00%> (ø)
...ule/dynamic_avoidance/dynamic_avoidance_module.cpp 0.00% <0.00%> (ø)
...ner/src/scene_module/dynamic_avoidance/manager.cpp 0.00% <0.00%> (ø)
...er/src/utils/drivable_area_expansion/expansion.cpp 39.87% <100.00%> (+7.46%) ⬆️

... and 380 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxime-clem maxime-clem enabled auto-merge (squash) August 8, 2023 04:54
@maxime-clem maxime-clem merged commit 95695f4 into autowarefoundation:main Aug 8, 2023
@maxime-clem maxime-clem deleted the fix/dynamic_drivable_area-avoid_line_dist branch August 8, 2023 05:29
mkuri pushed a commit to tier4/autoware.universe that referenced this pull request Aug 10, 2023
… parameter (autowarefoundation#4198)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
LeoDriveProject pushed a commit to leo-drive/autoware.universe.golf that referenced this pull request Aug 16, 2023
… parameter (autowarefoundation#4198)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem added a commit to maxime-clem/autoware.universe that referenced this pull request Aug 23, 2023
… parameter (autowarefoundation#4198)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem added a commit to maxime-clem/autoware.universe that referenced this pull request Aug 24, 2023
… parameter (autowarefoundation#4198)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
maxime-clem added a commit to maxime-clem/autoware.universe that referenced this pull request Aug 28, 2023
… parameter (autowarefoundation#4198)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
t4-x2 pushed a commit to tier4/autoware.universe that referenced this pull request Aug 29, 2023
… parameter (autowarefoundation#4198)

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants