Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): fix execution request condition #4197

Merged

Conversation

rej55
Copy link
Contributor

@rej55 rej55 commented Jul 7, 2023

Description

Before this change, the stop point is inserted by lane change module if the lane change is required.
However, the section to lane change is too short, it is not able to insert stop point because the lane change module does not run.

To fix this problem, I changed to run lane change module if the ego vehicle is not in preferred lane.

Related links

Tests performed

Tested in planning simulator.

TIER IV INTERNAL TEST

Notes for reviewers

Interface changes

Nothing.

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: +0.03 🎉

Comparison is base (4001ee6) 14.20% compared to head (5b68926) 14.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4197      +/-   ##
==========================================
+ Coverage   14.20%   14.24%   +0.03%     
==========================================
  Files        1594     1594              
  Lines      109844   111565    +1721     
  Branches    31569    32863    +1294     
==========================================
+ Hits        15604    15888     +284     
- Misses      77292    78466    +1174     
- Partials    16948    17211     +263     
Flag Coverage Δ *Carryforward flag
differential 13.67% <33.33%> (?)
total 14.20% <ø> (+<0.01%) ⬆️ Carriedforward from 4001ee6

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...planner/src/scene_module/lane_change/interface.cpp 5.06% <0.00%> (ø)
...th_planner/src/scene_module/lane_change/normal.cpp 4.02% <50.00%> (-0.87%) ⬇️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rej55 rej55 force-pushed the fix/insert_stop_point_in_reference_path branch 2 times, most recently from 7f8d804 to 302d132 Compare July 10, 2023 04:48
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
@rej55 rej55 force-pushed the fix/insert_stop_point_in_reference_path branch from 302d132 to 5b68926 Compare July 10, 2023 07:20
@rej55 rej55 changed the title fix(behavior_path_planner): insert stop point in root reference path fix(behavior_path_planner): fix execution request condition Jul 10, 2023
@rej55 rej55 merged commit 3dfebad into autowarefoundation:main Jul 10, 2023
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants