-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(obstacle_avoidance_planner): adding missing functionality for footprint marker #4193
Conversation
2bbcf4a
to
17e0152
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4193 +/- ##
==========================================
- Coverage 15.16% 15.05% -0.12%
==========================================
Files 1496 1508 +12
Lines 102997 103630 +633
Branches 31636 31645 +9
==========================================
- Hits 15624 15598 -26
- Misses 70365 71034 +669
+ Partials 17008 16998 -10
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
17e0152
to
88114e0
Compare
@mehmetdogru : May you please have a look and confirm it is doing the functionality intended as original implementation ? |
88114e0
to
13a6ff2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for the implementation
13a6ff2
to
ba84dbd
Compare
e4265aa
to
66cc813
Compare
@TakaHoribe - @kosuke55 - @takayuki5168 : |
planning/obstacle_avoidance_planner/include/obstacle_avoidance_planner/common_structs.hpp
Outdated
Show resolved
Hide resolved
…tprint marker Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
… original PR Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
…when AW is able to recover from footprint out of drivable area (to clear the polygon) Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
…optional Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
c7f73a3
to
2d5a4db
Compare
Description
This PR is to add missing functionality of footprint marker in
obstacle_avoidance_planner
since refactoring done in #2796 .Related links
closes #4190
Tests performed
Same as mentioned in original PR : #2689
Notes for reviewers
Original PR : #2689
Refactoring PR : #2796
Interface changes
N.A.
Effects on system behavior
This PR creates a separate footprint marker and appends it to
marker_array
inobstacle_avoidance_planner
for easier debugging.Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.