Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(obstacle_avoidance_planner): adding missing functionality for footprint marker #4193

Conversation

ahmeddesokyebrahim
Copy link
Contributor

@ahmeddesokyebrahim ahmeddesokyebrahim commented Jul 7, 2023

Description

This PR is to add missing functionality of footprint marker in obstacle_avoidance_planner since refactoring done in #2796 .

Related links

closes #4190

Tests performed

Same as mentioned in original PR : #2689

Notes for reviewers

Original PR : #2689
Refactoring PR : #2796

Interface changes

N.A.

Effects on system behavior

This PR creates a separate footprint marker and appends it to marker_array in obstacle_avoidance_planner for easier debugging.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 7, 2023
@ahmeddesokyebrahim ahmeddesokyebrahim self-assigned this Jul 7, 2023
@ahmeddesokyebrahim ahmeddesokyebrahim changed the title fix(obstacle_avoidance_planner): adding missing functionality for footprint maker fix(obstacle_avoidance_planner): adding missing functionality for footprint marker Jul 7, 2023
@ahmeddesokyebrahim ahmeddesokyebrahim force-pushed the autoware/universe/4190-add-missing-func-oap-footprint-marker branch from 2bbcf4a to 17e0152 Compare July 7, 2023 09:33
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.12 ⚠️

Comparison is base (91a8432) 15.16% compared to head (2d5a4db) 15.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4193      +/-   ##
==========================================
- Coverage   15.16%   15.05%   -0.12%     
==========================================
  Files        1496     1508      +12     
  Lines      102997   103630     +633     
  Branches    31636    31645       +9     
==========================================
- Hits        15624    15598      -26     
- Misses      70365    71034     +669     
+ Partials    17008    16998      -10     
Flag Coverage Δ *Carryforward flag
differential 39.27% <0.00%> (?)
total 15.05% <0.00%> (-0.12%) ⬇️ Carriedforward from d0685fc

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...alizer/src/camera/camera_pose_initializer_core.cpp 0.00% <ø> (ø)
...bloc_pose_initializer/src/camera/marker_module.cpp 0.00% <ø> (ø)
...ject_tracker/data_association/data_association.hpp 0.00% <0.00%> (ø)
...association/solver/mu_successive_shortest_path.hpp 0.00% <0.00%> (ø)
..._object_tracker_node/radar_object_tracker_node.hpp 0.00% <0.00%> (ø)
...ct_tracker/tracker/model/linear_motion_tracker.hpp 0.00% <0.00%> (ø)
...adar_object_tracker/tracker/model/tracker_base.hpp 0.00% <0.00%> (ø)
..._tracker/src/data_association/data_association.cpp 0.00% <0.00%> (ø)
...rtest_path/mu_successive_shortest_path_wrapper.cpp 0.00% <0.00%> (ø)
..._object_tracker_node/radar_object_tracker_node.cpp 0.00% <0.00%> (ø)
... and 9 more

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ahmeddesokyebrahim ahmeddesokyebrahim force-pushed the autoware/universe/4190-add-missing-func-oap-footprint-marker branch from 17e0152 to 88114e0 Compare July 10, 2023 21:46
@ahmeddesokyebrahim ahmeddesokyebrahim marked this pull request as ready for review July 10, 2023 21:46
@ahmeddesokyebrahim
Copy link
Contributor Author

@mehmetdogru : May you please have a look and confirm it is doing the functionality intended as original implementation ?

@ahmeddesokyebrahim ahmeddesokyebrahim force-pushed the autoware/universe/4190-add-missing-func-oap-footprint-marker branch from 88114e0 to 13a6ff2 Compare July 11, 2023 11:08
Copy link
Contributor

@mehmetdogru mehmetdogru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the implementation

@ahmeddesokyebrahim ahmeddesokyebrahim force-pushed the autoware/universe/4190-add-missing-func-oap-footprint-marker branch from 13a6ff2 to ba84dbd Compare July 11, 2023 15:25
@ahmeddesokyebrahim ahmeddesokyebrahim force-pushed the autoware/universe/4190-add-missing-func-oap-footprint-marker branch 2 times, most recently from e4265aa to 66cc813 Compare July 19, 2023 12:55
@ahmeddesokyebrahim
Copy link
Contributor Author

@TakaHoribe - @kosuke55 - @takayuki5168 :
May anyone have a look please ?

…tprint marker

Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
… original PR

Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
…when AW is able to recover from footprint out of drivable area (to clear the polygon)

Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
…optional

Signed-off-by: AhmedEbrahim <ahmed.a.d.ebrahim@gmail.com>
@ahmeddesokyebrahim ahmeddesokyebrahim force-pushed the autoware/universe/4190-add-missing-func-oap-footprint-marker branch from c7f73a3 to 2d5a4db Compare July 20, 2023 09:27
@ahmeddesokyebrahim ahmeddesokyebrahim merged commit 8e2f26e into autowarefoundation:main Jul 24, 2023
@ahmeddesokyebrahim ahmeddesokyebrahim deleted the autoware/universe/4190-add-missing-func-oap-footprint-marker branch July 24, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Adding missing PRs to obstacle_avoidance_planner since code refactoring
3 participants