Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dynamic_avoidance): ignore objects on LC target lane #4137

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Jun 30, 2023

Description

Does not avoid objects by the dynamic avoidance module on the target lane of the ego's lane changing
image

Tests performed

planning simulator

Effects on system behavior

does not avoid objects on the target lane of ego's lane changing

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 30, 2023
@takayuki5168 takayuki5168 changed the title feat(autoware_launch): add min_obj_lat_offset_to_ego_path in dynamic_avoidance fix(dynamic_avoidance): ignore objects on LC target lane Jun 30, 2023
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
We tested on a real vehicle.

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (879a837) 14.30% compared to head (4f7fc2c) 14.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4137      +/-   ##
==========================================
- Coverage   14.30%   14.30%   -0.01%     
==========================================
  Files        1570     1570              
  Lines      108297   108306       +9     
  Branches    31336    31342       +6     
==========================================
  Hits        15489    15489              
- Misses      75968    75975       +7     
- Partials    16840    16842       +2     
Flag Coverage Δ *Carryforward flag
differential 13.47% <0.00%> (?)
total 14.30% <ø> (ø) Carriedforward from bf68b45

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ule/dynamic_avoidance/dynamic_avoidance_module.hpp 0.00% <ø> (ø)
...ule/dynamic_avoidance/dynamic_avoidance_module.cpp 0.00% <0.00%> (ø)
...ner/src/scene_module/dynamic_avoidance/manager.cpp 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 merged commit 1419f32 into autowarefoundation:main Jul 6, 2023
@takayuki5168 takayuki5168 deleted the fix/ignore-dynamic-avoidance-on-LC-target-lane branch July 6, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants