-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dynamic_avoidance): ignore objects on LC target lane #4137
fix(dynamic_avoidance): ignore objects on LC target lane #4137
Conversation
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
b538a43
to
ca643cc
Compare
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
We tested on a real vehicle.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4137 +/- ##
==========================================
- Coverage 14.30% 14.30% -0.01%
==========================================
Files 1570 1570
Lines 108297 108306 +9
Branches 31336 31342 +6
==========================================
Hits 15489 15489
- Misses 75968 75975 +7
- Partials 16840 16842 +2
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Description
Does not avoid objects by the dynamic avoidance module on the target lane of the ego's lane changing
![image](https://private-user-images.githubusercontent.com/20228327/249766811-6bda30e8-4a16-4851-a12a-cba9422e4335.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzNjgzMjYsIm5iZiI6MTczOTM2ODAyNiwicGF0aCI6Ii8yMDIyODMyNy8yNDk3NjY4MTEtNmJkYTMwZTgtNGExNi00ODUxLWExMmEtY2JhOTQyMmU0MzM1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEyVDEzNDcwNlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTI0ZTYwZjU5NTE0NTY5MzUyYzljNzU3MjIzY2Y2OTQ3MWNjMDU5ZTU2N2MyZmZlYWZkMWJhMGQwNTVhMDI2ZTUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.8_QiM6pOsTyFP7q_qebHUOFJ5Pl1Dswe1I03JyWmc8o)
Tests performed
planning simulator
Effects on system behavior
does not avoid objects on the target lane of ego's lane changing
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.