Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(mission_planner): use lower case #4079

Merged
merged 2 commits into from
Jun 26, 2023

Conversation

purewater0901
Copy link
Contributor

Description

Use lower case for the reroute safety check function

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yutaka <purewater0901@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 26, 2023
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@purewater0901 purewater0901 enabled auto-merge (squash) June 26, 2023 07:28
@purewater0901 purewater0901 disabled auto-merge June 26, 2023 11:54
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (68a24de) 14.36% compared to head (6bb11ba) 14.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4079      +/-   ##
==========================================
- Coverage   14.36%   14.36%   -0.01%     
==========================================
  Files        1566     1566              
  Lines      107737   107720      -17     
  Branches    31175    31168       -7     
==========================================
- Hits        15481    15476       -5     
+ Misses      75429    75419      -10     
+ Partials    16827    16825       -2     
Flag Coverage Δ *Carryforward flag
differential 12.75% <0.00%> (?)
total 14.36% <ø> (-0.01%) ⬇️ Carriedforward from 435cdf9

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...occupancy_grid_map_binary_bayes_filter_updater.cpp 0.00% <ø> (ø)
...nner/utils/lane_change/lane_change_module_data.hpp 50.00% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 18.44% <ø> (ø)
...th_planner/src/scene_module/lane_change/normal.cpp 4.42% <ø> (-0.48%) ⬇️
...avior_path_planner/src/utils/lane_change/utils.cpp 0.44% <ø> (ø)
...on_planner/src/mission_planner/mission_planner.cpp 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@purewater0901 purewater0901 merged commit 3e12df8 into main Jun 26, 2023
@purewater0901 purewater0901 deleted the refactor/use-lowercase-reroute-safety branch June 26, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants