Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lane_change): add z-pos in debug marker #4074

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Jun 26, 2023

Description

Add z-pos in debug marker.

Tests performed

Check in the Psim
image

Not applicable.

Effects on system behavior

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 26, 2023
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TakaHoribe TakaHoribe enabled auto-merge (squash) June 26, 2023 02:42
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (40f9311) 14.36% compared to head (de7982f) 14.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4074      +/-   ##
==========================================
- Coverage   14.36%   14.36%   -0.01%     
==========================================
  Files        1566     1566              
  Lines      107725   107740      +15     
  Branches    31175    31189      +14     
==========================================
+ Hits        15480    15482       +2     
- Misses      75418    75422       +4     
- Partials    16827    16836       +9     
Flag Coverage Δ *Carryforward flag
differential 13.63% <0.00%> (?)
total 14.37% <ø> (+<0.01%) ⬆️ Carriedforward from 40f9311

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...path_planner/src/marker_util/lane_change/debug.cpp 0.00% <0.00%> (ø)
..._velocity_crosswalk_module/src/scene_crosswalk.cpp 0.00% <ø> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TakaHoribe TakaHoribe merged commit 261a1b2 into autowarefoundation:main Jun 26, 2023
@TakaHoribe TakaHoribe deleted the fix-lc-viz-z branch June 26, 2023 03:14
rej55 pushed a commit to tier4/autoware.universe that referenced this pull request Jun 29, 2023
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
rej55 pushed a commit to tier4/autoware.universe that referenced this pull request Jul 4, 2023
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
rej55 pushed a commit to tier4/autoware.universe that referenced this pull request Jul 5, 2023
Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants