fix(route_handler): check all co-located lanes for generating path #4013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4013 +/- ##
==========================================
- Coverage 14.28% 14.25% -0.04%
==========================================
Files 1575 1575
Lines 108532 109723 +1191
Branches 31418 32302 +884
==========================================
+ Hits 15507 15640 +133
- Misses 76155 77080 +925
- Partials 16870 17003 +133
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
b2b25f3 to
d06925c
Compare
maxime-clem
approved these changes
Jul 6, 2023
d06925c to
2d7e347
Compare
Signed-off-by: beyza <bnk@leodrive.ai>
36d61d6 to
9933aa2
Compare
|
@maxime-clem There were some conflicts this PR. I solved it but I had to add new commits. So can you check and approve again? |
maxime-clem
approved these changes
Jul 7, 2023
e54f534 to
206e4db
Compare
Signed-off-by: beyza <bnk@leodrive.ai>
ce4bba4 to
076f73f
Compare
|
@maxime-clem I and @ahmeddesokyebrahim worked together on conflicts. I pushed the last version of this PR. Can you review it again? |
|
@zulfaqar-azmi-t4 @purewater0901 @kosuke55 @rej55 since you are the code owners can you check/review the PR and approve? |
mehmetdogru
approved these changes
Jul 10, 2023
TakaHoribe
added a commit
to tier4/autoware.universe
that referenced
this pull request
Jul 12, 2023
… path (autowarefoundation#4013)" This reverts commit 98b4f90.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes: 3586
Tests performed
current route_handler package
consider co-located lanelet for generating path
Effects on system behavior
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.