Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pull_out): change pull out finish deviation threshold #3917

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Jun 7, 2023

Description

pull out finish causes avoidance to cancel.

pull_out_avoidance-2023-06-07_19.06.08.mp4

In this PR, change the deviation threshold for finishing pull out, the value referred to lane change #3861

Related links

tier4 internal ticket

Tests performed

psim

Notes for reviewers

Interface changes

not applicable

Effects on system behavior

not applicable

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the feat/change_pull_out_finish_condition branch from 73265f4 to 03470e9 Compare June 7, 2023 12:02
@TomohitoAndo TomohitoAndo changed the title feat(pull_out): change pull out finish deviation threshould feat(pull_out): change pull out finish deviation threshold Jun 7, 2023
@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch coverage: 19.14% and project coverage change: -0.02 ⚠️

Comparison is base (35bc65a) 14.05% compared to head (03470e9) 14.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3917      +/-   ##
==========================================
- Coverage   14.05%   14.04%   -0.02%     
==========================================
  Files        1456     1459       +3     
  Lines      102521   102872     +351     
  Branches    27295    27589     +294     
==========================================
+ Hits        14411    14449      +38     
- Misses      72323    72616     +293     
- Partials    15787    15807      +20     
Flag Coverage Δ *Carryforward flag
differential 13.08% <19.14%> (?)
total 14.08% <ø> (+0.03%) ⬆️ Carriedforward from b2f4517

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
.../rtc_manager_rviz_plugin/src/rtc_manager_panel.cpp 0.00% <ø> (ø)
...viz_plugin/src/velocity_steering_factors_panel.cpp 0.00% <ø> (ø)
...anner/include/behavior_path_planner/parameters.hpp 50.00% <ø> (ø)
...cene_module/start_planner/start_planner_module.hpp 50.00% <ø> (ø)
...planner/utils/start_planner/geometric_pull_out.hpp 0.00% <ø> (ø)
...path_planner/utils/start_planner/pull_out_path.hpp 0.00% <ø> (ø)
...ath_planner/utils/start_planner/shift_pull_out.hpp 0.00% <ø> (ø)
...r/utils/start_planner/start_planner_parameters.hpp 0.00% <0.00%> (ø)
...nner/include/behavior_path_planner/utils/utils.hpp 45.45% <ø> (ø)
.../scene_module/goal_planner/goal_planner_module.cpp 5.13% <ø> (ø)
... and 12 more

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kosuke55 kosuke55 merged commit 68f6f2f into main Jun 7, 2023
@kosuke55 kosuke55 deleted the feat/change_pull_out_finish_condition branch June 7, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants