Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable some options for object visualization #3907

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

tkimura4
Copy link
Contributor

@tkimura4 tkimura4 commented Jun 6, 2023

Description

In the object visualization plugin in the autoware_auto_perception_rviz_plugin, the options for computational cost reduction (Polygon Type, Visualization Type) is unavailable now. I fixed it.

Tests performed

Before:
image

After:
image

Effects on system behavior

Not applicable. (It affects only RViz. )

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
@tkimura4 tkimura4 requested a review from shmpwk June 6, 2023 05:25
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Jun 6, 2023
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.19 ⚠️

Comparison is base (dc9282d) 14.08% compared to head (d8af70f) 13.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3907      +/-   ##
==========================================
- Coverage   14.08%   13.90%   -0.19%     
==========================================
  Files        1447     1447              
  Lines      102302   101667     -635     
  Branches    27342    26996     -346     
==========================================
- Hits        14409    14134     -275     
+ Misses      72081    72026      -55     
+ Partials    15812    15507     -305     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 13.90% <ø> (-0.19%) ⬇️ Carriedforward from dc9282d

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...e/object_detection/object_polygon_display_base.hpp 0.00% <ø> (ø)
..._controller/include/mpc_lateral_controller/mpc.hpp 85.71% <ø> (+39.04%) ⬆️
.../include/mpc_lateral_controller/mpc_trajectory.hpp 50.00% <ø> (ø)
...pc_lateral_controller/qp_solver/qp_solver_osqp.hpp 0.00% <ø> (ø)
...l_controller/qp_solver/qp_solver_unconstr_fast.hpp 100.00% <ø> (ø)
...r/vehicle_model/vehicle_model_bicycle_dynamics.hpp 100.00% <ø> (ø)
...vehicle_model/vehicle_model_bicycle_kinematics.hpp 100.00% <ø> (ø)
...odel/vehicle_model_bicycle_kinematics_no_delay.hpp 100.00% <ø> (ø)
control/mpc_lateral_controller/src/mpc.cpp 57.72% <ø> (+7.35%) ⬆️
..._lateral_controller/src/mpc_lateral_controller.cpp 47.72% <ø> (+14.29%) ⬆️
... and 5 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@1222-takeshi 1222-takeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 merged commit abbf81e into autowarefoundation:main Jun 6, 2023
@tkimura4 tkimura4 deleted the fix/object_viz_option branch June 6, 2023 10:48
tkimura4 added a commit to tier4/autoware.universe that referenced this pull request Jun 6, 2023
…n#3907)

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants