fix(pointcloud_preprocessor): change velocoty_report to twist_with_covariance #3877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shunsuke Miura <shunsuke.miura@tier4.jp>
kminoda
reviewed
May 31, 2023
...d_preprocessor/include/pointcloud_preprocessor/concatenate_data/concatenate_data_nodelet.hpp
Show resolved
Hide resolved
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #3877 +/- ##
=======================================
Coverage 14.12% 14.12%
=======================================
Files 1444 1444
Lines 101944 101941 -3
Branches 27199 27199
=======================================
Hits 14395 14395
+ Misses 71776 71773 -3
Partials 15773 15773
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
@yukkysaito Can I get your approve as a codeowner? |
This was referenced Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Even the ego vehicle twist topic is changed to
/sensing/vehicle_velocity_converter/twist_with_covariancein #1120, concatenate data node still uses/vehicle/status/velocity_status.Since the velocity in
vehicle_velocity_converter/twist_with_covarianceis different fromvelocity_statusafter #2641, the velocity used in the sensing stack should be only twist_with_covarianceRelated links
autowarefoundation/sample_sensor_kit_launch#59
TIER IV INTERNAL LINK
Tests performed
Confirmed by logging simulator
Notes for reviewers
Interface changes
Sensing module internal topic change.
Change input topic of concatenate_data from velocoty_report to twist_with_covariance
Effects on system behavior
point clouds are concatenated with correct odometry compensation.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.