Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(intersection): add the flag for intersection_occlusion grid publication #3844

Conversation

soblin
Copy link
Contributor

@soblin soblin commented May 26, 2023

Description

Add the option to publish intersection_occlusion grid when intersection_occlusion feature is enabled.

launcher PR: autowarefoundation/autoware_launch#372

Tests performed

On Psim

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…cation

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 26, 2023
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (35a346d) 14.11% compared to head (2698c1e) 14.11%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3844      +/-   ##
==========================================
- Coverage   14.11%   14.11%   -0.01%     
==========================================
  Files        1438     1438              
  Lines      101549   101552       +3     
  Branches    27063    27063              
==========================================
  Hits        14330    14330              
- Misses      71531    71534       +3     
  Partials    15688    15688              
Flag Coverage Δ *Carryforward flag
differential 5.04% <0.00%> (?)
total 14.11% <ø> (+<0.01%) ⬆️ Carriedforward from 35a346d

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...avior_velocity_intersection_module/src/manager.cpp 0.00% <0.00%> (ø)
...ity_intersection_module/src/scene_intersection.cpp 0.00% <0.00%> (ø)
...ity_intersection_module/src/scene_intersection.hpp 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@soblin soblin merged commit 72d889a into autowarefoundation:main May 26, 2023
@soblin soblin deleted the chore/intersection-occlusion-debug-pub-option branch May 26, 2023 12:34
tkimura4 pushed a commit to tier4/autoware.universe that referenced this pull request May 29, 2023
…cation (autowarefoundation#3844)

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
tkimura4 added a commit to tier4/autoware.universe that referenced this pull request May 29, 2023
* feat(intersection): denoise occlusion by morphology open process (autowarefoundation#3763)

* apply morpholgoyEx to occlusion_mask_raw to remove noisy occlusion cell

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* parameterize kernel size

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* remove debug

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

---------

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>

* fix(intersection): add the flag for intersection_occlusion grid publication (autowarefoundation#3844)

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

---------

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Co-authored-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin added a commit to tier4/autoware.universe that referenced this pull request May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants