Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_velocity_speed_bump_module): use unique virtual wall namespace #3838

Conversation

maxime-clem
Copy link
Contributor

Description

Use the (unique) module_id_ as namespace prefix for the virtual wall markers generated by the speed bump scenes.

Tests performed

Tested in the planning simulation.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…espace

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 26, 2023
Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.97 🎉

Comparison is base (358d4a7) 14.09% compared to head (dd6dbb0) 15.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3838      +/-   ##
==========================================
+ Coverage   14.09%   15.07%   +0.97%     
==========================================
  Files        1438     1332     -106     
  Lines      101620    95010    -6610     
  Branches    27045    27045              
==========================================
- Hits        14328    14326       -2     
+ Misses      71607    64998    -6609     
- Partials    15685    15686       +1     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 15.07% <ø> (+0.97%) ⬆️ Carriedforward from 358d4a7

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
.../behavior_velocity_speed_bump_module/src/debug.cpp 0.00% <0.00%> (ø)

... and 108 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxime-clem maxime-clem merged commit 2af2daa into autowarefoundation:main May 26, 2023
@maxime-clem maxime-clem deleted the fix/behavior_velocity_planner_speed_bump_module-virtual_wall_markers branch May 26, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants