Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stopline): fix virtual wall marker id duplication #3835

Merged

Conversation

soblin
Copy link
Contributor

@soblin soblin commented May 26, 2023

Description

Fixed stopline module to use module_id_ for virtual wall marker creator.

Related links

Tests performed

Before this PR

The first stopline virtual wall on the path is not visualized due to the error
image

After this PR

image

Notes for reviewers

Interface changes

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 26, 2023
@soblin soblin marked this pull request as ready for review May 26, 2023 06:19
@soblin soblin requested a review from kyoichi-sugahara May 26, 2023 06:46
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (712c11c) 14.11% compared to head (1a683bf) 14.11%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3835   +/-   ##
=======================================
  Coverage   14.11%   14.11%           
=======================================
  Files        1438     1438           
  Lines      101526   101515   -11     
  Branches    27045    27045           
=======================================
  Hits        14328    14328           
+ Misses      71513    71502   -11     
  Partials    15685    15685           
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 14.11% <ø> (+<0.01%) ⬆️ Carriedforward from 712c11c

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...g/behavior_velocity_stop_line_module/src/debug.cpp 0.00% <0.00%> (ø)
...on_planner/src/mission_planner/mission_planner.cpp 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants