Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mission_planner): subtract goal distance from the accumulated length #3818

Merged
merged 3 commits into from
May 25, 2023

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented May 25, 2023

Description

Subtract goal distance from the accumulated length when checking the rerouting safety

Tests performed

Planning Simulator

Screencast.from.05-25-2023.07.17.40.PM.webm

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
Signed-off-by: yutaka <purewater0901@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 25, 2023
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2ea192b) 14.11% compared to head (d2c9016) 14.12%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3818   +/-   ##
=======================================
  Coverage   14.11%   14.12%           
=======================================
  Files        1438     1438           
  Lines      101482   101458   -24     
  Branches    27045    27045           
=======================================
  Hits        14329    14329           
+ Misses      71469    71445   -24     
  Partials    15684    15684           
Flag Coverage Δ *Carryforward flag
differential 15.08% <0.00%> (?)
total 14.13% <ø> (+0.01%) ⬆️ Carriedforward from 94a2418

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...king/include/autonomous_emergency_braking/node.hpp 0.00% <ø> (ø)
control/autonomous_emergency_braking/src/node.cpp 0.00% <ø> (ø)
...on_planner/src/mission_planner/mission_planner.cpp 0.00% <0.00%> (ø)
...tem/system_monitor/src/mem_monitor/mem_monitor.cpp 0.00% <ø> (ø)

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@purewater0901 purewater0901 merged commit 712c11c into main May 25, 2023
@purewater0901 purewater0901 deleted the fix/subtract-goal-dist branch May 25, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants