Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pull_out): support pull out normal lane #3805

Merged
merged 3 commits into from
May 31, 2023
Merged

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented May 24, 2023

Description

  • pull out from the road lane not just road_shoulder
  • always execute pull out when a new route is received and ego-vehicle is stopped.
  • disable the blinker if the lateral shift offset is smaller than th_blinker_on_lateral_offset: 1.0

red arrow: pull out start point
yellow arrow: pull out end point

image

image

image

image

Related links

Tests performed

psim
tier4 internal scenario test 1339/1372

(baseline
https://evaluation.tier4.jp/evaluation/reports/90dcdc1b-b5b3-58d8-85ad-0c28654b65a0?project_id=prd_jt
1330/1372)

new archi
https://evaluation.tier4.jp/evaluation/reports/a62d2285-9947-57fa-b673-7dd30854accc?project_id=prd_jt
1302/1372
not degrated

Notes for reviewers

Interface changes

not applicable

Effects on system behavior

not applicable

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label May 24, 2023
@kosuke55 kosuke55 force-pushed the feat/pull_out_normal_lane branch 2 times, most recently from d930a83 to a146c15 Compare May 24, 2023 12:11
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label May 24, 2023
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Patch coverage: 19.04% and project coverage change: +0.07 🎉

Comparison is base (1e8b9d5) 14.11% compared to head (b10920b) 14.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3805      +/-   ##
==========================================
+ Coverage   14.11%   14.19%   +0.07%     
==========================================
  Files        1444     1444              
  Lines      101841   102291     +450     
  Branches    27151    27527     +376     
==========================================
+ Hits        14378    14519     +141     
- Misses      71711    71818     +107     
- Partials    15752    15954     +202     
Flag Coverage Δ *Carryforward flag
differential 13.23% <19.04%> (?)
total 14.12% <ø> (+<0.01%) ⬆️ Carriedforward from 1e8b9d5

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ner/include/behavior_path_planner/data_manager.hpp 37.50% <ø> (ø)
..._planner/scene_module/pull_out/pull_out_module.hpp 50.00% <0.00%> (-16.67%) ⬇️
...ath_planner/utils/pull_out/pull_out_parameters.hpp 0.00% <ø> (ø)
...vior_path_planner/utils/pull_out/pull_out_path.hpp 0.00% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 24.69% <0.00%> (+5.73%) ⬆️
...path_planner/src/utils/pull_out/shift_pull_out.cpp 3.44% <0.00%> (-0.16%) ⬇️
...nner/src/scene_module/pull_out/pull_out_module.cpp 5.94% <22.58%> (+2.22%) ⬆️
.../behavior_path_planner/src/utils/pull_out/util.cpp 11.42% <33.33%> (+0.31%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kosuke55 kosuke55 force-pushed the feat/pull_out_normal_lane branch 3 times, most recently from 065f72e to c5a787d Compare May 25, 2023 15:32
@github-actions github-actions bot removed the type:documentation Creating or refining documentation. (auto-assigned) label May 25, 2023
@kosuke55 kosuke55 force-pushed the feat/pull_out_normal_lane branch from c5a787d to 0223157 Compare May 25, 2023 15:33
@github-actions github-actions bot added the type:documentation Creating or refining documentation. (auto-assigned) label May 28, 2023
@kosuke55 kosuke55 force-pushed the feat/pull_out_normal_lane branch 6 times, most recently from 8def93c to ec1844e Compare May 30, 2023 11:07
@kosuke55 kosuke55 marked this pull request as ready for review May 30, 2023 11:08
@kosuke55 kosuke55 changed the title Feat/pull out normal lane feat(pull_out): support pull out normal lane May 30, 2023
@kosuke55 kosuke55 changed the title feat(pull_out): support pull out normal lane feat(pull_out): support pull out normal lane May 30, 2023
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the feat/pull_out_normal_lane branch from ec1844e to 83aaa3f Compare May 31, 2023 04:14
Copy link
Contributor

@rej55 rej55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kosuke55 added 2 commits May 31, 2023 18:00
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 merged commit 7b7ac9d into main May 31, 2023
@kosuke55 kosuke55 deleted the feat/pull_out_normal_lane branch May 31, 2023 10:47
@kosuke55
Copy link
Contributor Author

kosuke55 commented Jun 7, 2023

rename start_planner in #3908

shmpwk pushed a commit to tier4/autoware.universe that referenced this pull request Jun 8, 2023
* feat(pull_out): support pull out normal lane

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* fix werror

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* change params

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

---------

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants