-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pull_out): support pull out normal lane #3805
Conversation
d930a83
to
a146c15
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3805 +/- ##
==========================================
+ Coverage 14.11% 14.19% +0.07%
==========================================
Files 1444 1444
Lines 101841 102291 +450
Branches 27151 27527 +376
==========================================
+ Hits 14378 14519 +141
- Misses 71711 71818 +107
- Partials 15752 15954 +202
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
065f72e
to
c5a787d
Compare
c5a787d
to
0223157
Compare
8def93c
to
ec1844e
Compare
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
ec1844e
to
83aaa3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
rename |
* feat(pull_out): support pull out normal lane Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * fix werror Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> * change params Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> --------- Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Description
road_shoulder
th_blinker_on_lateral_offset: 1.0
red arrow: pull out start point
yellow arrow: pull out end point
Related links
Tests performed
psim
tier4 internal scenario test 1339/1372
(baseline
https://evaluation.tier4.jp/evaluation/reports/90dcdc1b-b5b3-58d8-85ad-0c28654b65a0?project_id=prd_jt
1330/1372)
new archi
https://evaluation.tier4.jp/evaluation/reports/a62d2285-9947-57fa-b673-7dd30854accc?project_id=prd_jt
1302/1372
not degrated
Notes for reviewers
Interface changes
not applicable
Effects on system behavior
not applicable
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.