Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(accel_brake_map_calibrator): fix view_statistics script #3793

Merged
merged 1 commit into from
May 26, 2023

Conversation

tkimura4
Copy link
Contributor

@tkimura4 tkimura4 commented May 23, 2023

Description

I fixed view_statistics.py script in the accel_brake_map_calibrator package.

After:

Tests performed

Before:
The script causes the following error.
image

After:
The script can output matplot image
image

Effects on system behavior

It does not affect autonomous driving behavior.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
@tkimura4 tkimura4 requested review from taikitanaka3, 1222-takeshi and a team as code owners May 23, 2023 03:14
@github-actions github-actions bot added the component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned) label May 23, 2023
Copy link
Contributor

@shmpwk shmpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (010523f) 15.10% compared to head (07c4814) 15.10%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3793   +/-   ##
=======================================
  Coverage   15.10%   15.10%           
=======================================
  Files        1332     1332           
  Lines       94823    94823           
  Branches    27009    27009           
=======================================
  Hits        14321    14321           
  Misses      64813    64813           
  Partials    15689    15689           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 15.10% <ø> (ø) Carriedforward from 010523f

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@1222-takeshi 1222-takeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 enabled auto-merge (squash) May 26, 2023 08:47
@tkimura4 tkimura4 merged commit 49d853c into autowarefoundation:main May 26, 2023
@tkimura4 tkimura4 deleted the fix/view_statistics branch May 26, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:vehicle Vehicle-specific implementations, drivers, packages. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants