Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(velocity_controller): debug value for feedforward #3782

Merged

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented May 22, 2023

Description

Feedforward acceleration term is in the FF_SCALE, which is wrong.

Tests performed

run psim

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takamasa Horibe <horibe.takamasa@gmail.com>
@TakaHoribe TakaHoribe requested review from takayuki5168 and a team as code owners May 22, 2023 06:05
@github-actions github-actions bot added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label May 22, 2023
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c16ba06) 14.51% compared to head (72e9191) 14.51%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3782   +/-   ##
=======================================
  Coverage   14.51%   14.51%           
=======================================
  Files        1442     1442           
  Lines      101582   101582           
  Branches    30204    30204           
=======================================
  Hits        14747    14747           
  Misses      70691    70691           
  Partials    16144    16144           
Flag Coverage Δ *Carryforward flag
differential 42.16% <ø> (?)
total 14.51% <ø> (ø) Carriedforward from c16ba06

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...clude/pid_longitudinal_controller/debug_values.hpp 50.00% <ø> (ø)
...nal_controller/src/pid_longitudinal_controller.cpp 39.59% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TakaHoribe TakaHoribe merged commit 42d147b into autowarefoundation:main May 27, 2023
@TakaHoribe TakaHoribe deleted the fix-debug-val-velocity-controller branch May 27, 2023 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants