Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(map_loader): visualize hatched road markings #3639

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented May 8, 2023

Description

visualize hatched road markings area in LL2.
image

Discussion for introducing hatched road markings area.
https://github.com/orgs/autowarefoundation/discussions/3414

Tests performed

can visualize the area with planning simulator

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 marked this pull request as ready for review May 8, 2023 11:19
@github-actions github-actions bot added the component:map Map creation, storage, and loading. (auto-assigned) label May 8, 2023
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (52127f0) 14.69% compared to head (da589fc) 14.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3639      +/-   ##
==========================================
- Coverage   14.69%   14.69%   -0.01%     
==========================================
  Files        1297     1297              
  Lines       92187    92190       +3     
  Branches    29147    29147              
==========================================
  Hits        13550    13550              
- Misses      63980    63983       +3     
  Partials    14657    14657              
Flag Coverage Δ *Carryforward flag
differential 29.14% <0.00%> (?)
total 14.69% <ø> (ø) Carriedforward from 52127f0

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...et2_map_loader/lanelet2_map_visualization_node.cpp 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168 takayuki5168 merged commit f368b2a into autowarefoundation:main May 9, 2023
@takayuki5168 takayuki5168 deleted the feat/visualize-hatched-road-markings branch May 9, 2023 03:48
takayuki5168 added a commit to tier4/autoware.universe that referenced this pull request May 10, 2023
…#3639)

* feat(map_loader): visualize hatched road markings

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:map Map creation, storage, and loading. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants