refactor(obstacle_stop_planner): remove unnecessary variables and functions, improve code performance

[brkay54]

Description

In obstacle_stop_planner, I removed the unused function and variables. Also in some parts, pushPolygon function is called unnecessarily. Also to increase code efficiency, some changes made.

This should be merged after following PRs merged.

#3556
#3558

Tests performed

Tested in planning simulator and worked well.
Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (33075ca) 14.72% compared to head (41477e0) 14.71%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3560      +/-   ##
==========================================
- Coverage   14.72%   14.71%   -0.01%     
==========================================
  Files        1298     1298              
  Lines       92512    92533      +21     
  Branches    29309    29320      +11     
==========================================
+ Hits        13619    13620       +1     
- Misses      64113    64131      +18     
- Partials    14780    14782       +2     

Flag	Coverage Δ		*Carryforward flag
differential	8.75% <0.00%> (?)
total	14.72% <ø> (+<0.01%)	⬆️	Carriedforward from 33075ca

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
...ule/dynamic_avoidance/dynamic_avoidance_module.cpp	0.00% <ø> (ø)
...top_planner/include/obstacle_stop_planner/node.hpp	0.00% <ø> (ø)
...tacle_stop_planner/src/adaptive_cruise_control.cpp	1.52% <0.00%> (ø)
planning/obstacle_stop_planner/src/node.cpp	9.21% <0.00%> (-0.09%)	⬇️
...anning/obstacle_stop_planner/src/planner_utils.cpp	13.33% <0.00%> (-0.15%)	⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[satoshi-ota]

@brkay54 @mehmetdogru This PR looks good to me.

On the other hand, I found a little weird behavior related to obstacle_stop_planner, and I open a issue for the unexpected behavior.

So, I was hoping you could check the issue #3666 🙏

[brkay54]

@satoshi-ota Thank you, I will check the issue.