-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(obstacle_stop_planner): add filtering feature for predicted objects #3558
Conversation
ede49e6
to
793ca0c
Compare
planning/obstacle_stop_planner/include/obstacle_stop_planner/planner_data.hpp
Show resolved
Hide resolved
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3558 +/- ##
==========================================
- Coverage 13.82% 13.82% -0.01%
==========================================
Files 1395 1395
Lines 98206 98236 +30
Branches 29214 29211 -3
==========================================
Hits 13579 13579
- Misses 69950 69976 +26
- Partials 14677 14681 +4
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Berkay Karaman <brkay54@gmail.com>
@brkay54 Thanks for your improvement. It looks good to me. Lastly, could you fill Effects on system behavior briefly? |
@satoshi-ota Thank you for your review 🙏🏼 , I also rebased other PR too. |
Description
Note: #3556
This should be merged before this PR.
Because there are a lot of predicted objects in real environment, we need to filter it before collision and slowdown checking. It is filtering with respect to following rules.
Related links
PR for launch file: autowarefoundation/autoware_launch#330
Tests performed
Tested in planning simulator:
As you can see, it ignores high lateral distance objects.
Notes for reviewers
Interface changes
Effects on system behavior
There is no behavior change, it only increases node performance by using filtering.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.