Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(obstacle_stop_planner): add filtering feature for predicted objects #3558

Merged
merged 1 commit into from
May 10, 2023

Conversation

brkay54
Copy link
Member

@brkay54 brkay54 commented Apr 27, 2023

Description

Note: #3556
This should be merged before this PR.

Because there are a lot of predicted objects in real environment, we need to filter it before collision and slowdown checking. It is filtering with respect to following rules.

  • Ignore object if it is not front of vehicle
  • Ignore object if it's longitudinal distance is far away from trajectory's last point
  • Ignore object if lateral distance is high

Related links

PR for launch file: autowarefoundation/autoware_launch#330

Tests performed

Tested in planning simulator:

Screenshot from 2023-04-27 02-08-27

As you can see, it ignores high lateral distance objects.

Notes for reviewers

Interface changes

Effects on system behavior

There is no behavior change, it only increases node performance by using filtering.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@brkay54 brkay54 requested a review from satoshi-ota May 8, 2023 23:38
@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (9f7568c) 13.82% compared to head (fcf3f14) 13.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3558      +/-   ##
==========================================
- Coverage   13.82%   13.82%   -0.01%     
==========================================
  Files        1395     1395              
  Lines       98206    98236      +30     
  Branches    29214    29211       -3     
==========================================
  Hits        13579    13579              
- Misses      69950    69976      +26     
- Partials    14677    14681       +4     
Flag Coverage Δ *Carryforward flag
differential 8.54% <0.00%> (?)
total 13.85% <ø> (+0.03%) ⬆️ Carriedforward from 9f7568c

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...nner/include/behavior_path_planner/utils/utils.hpp 45.45% <ø> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp 3.68% <ø> (+0.01%) ⬆️
.../scene_module/goal_planner/goal_planner_module.cpp 5.97% <ø> (+0.03%) ⬆️
...th_planner/src/scene_module/lane_change/normal.cpp 6.66% <ø> (+0.02%) ⬆️
...nner/src/scene_module/pull_out/pull_out_module.cpp 3.78% <ø> (+0.06%) ⬆️
...ehavior_path_planner/src/utils/avoidance/utils.cpp 3.83% <ø> (+0.01%) ⬆️
planning/behavior_path_planner/src/utils/utils.cpp 16.04% <ø> (ø)
...top_planner/include/obstacle_stop_planner/node.hpp 0.00% <0.00%> (ø)
...tacle_stop_planner/src/adaptive_cruise_control.cpp 1.52% <0.00%> (-0.13%) ⬇️
planning/obstacle_stop_planner/src/node.cpp 8.86% <0.00%> (+0.04%) ⬆️
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Berkay Karaman <brkay54@gmail.com>
@satoshi-ota
Copy link
Contributor

@brkay54 Thanks for your improvement. It looks good to me. Lastly, could you fill Effects on system behavior briefly?

@brkay54 brkay54 merged commit c27059a into autowarefoundation:main May 10, 2023
@brkay54
Copy link
Member Author

brkay54 commented May 10, 2023

@satoshi-ota Thank you for your review 🙏🏼 , I also rebased other PR too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants