Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): run avoidance and pull out simultaneously #3481

Merged
merged 2 commits into from
Apr 25, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Apr 20, 2023

Description

run pull_out and avoidance simultaneously.

back -> shift pull out + avoidance

pull_out_avoidance-2023-04-20_20.48.19.mp4
pull_out_avoidance-2023-04-20_20.49.23.mp4

back -> geometric pull out + avoidance

pull_out_avoidance-2023-04-20_20.52.44.mp4

Related links

#3223

merge after #3480

autowarefoundation/autoware_launch#321

Tests performed

psim
tier4 internal scenario test 1323/1330

Notes for reviewers

Interface changes

no

Effects on system behavior

can run avoidance and pull out simultaneously

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Apr 20, 2023
@kosuke55 kosuke55 changed the title Feat/pull out avoidance feat(behavior_path_planner): run avoidance and pull out simultaneously Apr 20, 2023
@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b77bbf8) 14.05% compared to head (df86783) 14.05%.

❗ Current head df86783 differs from pull request most recent head c49d0d2. Consider uploading reports for the commit c49d0d2 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3481   +/-   ##
=======================================
  Coverage   14.05%   14.05%           
=======================================
  Files        1397     1397           
  Lines       98031    98038    +7     
  Branches    29105    29113    +8     
=======================================
+ Hits        13776    13784    +8     
+ Misses      69590    69588    -2     
- Partials    14665    14666    +1     
Flag Coverage Δ *Carryforward flag
differential 15.15% <0.00%> (?)
total 13.72% <ø> (-0.33%) ⬇️ Carriedforward from f2b7687

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...er/src/scene_module/avoidance/avoidance_module.cpp 3.35% <0.00%> (-0.01%) ⬇️
...nner/src/scene_module/pull_out/pull_out_module.cpp 6.02% <0.00%> (-0.12%) ⬇️

... and 10 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@satoshi-ota
Copy link
Contributor

@kosuke55 I think we should check the pull out + avoidance maneuver with RTC MANUAL (NOT AUTO) mode, too. Could you do that?

@kosuke55
Copy link
Contributor Author

merge #3491 first

@kosuke55
Copy link
Contributor Author

kosuke55 commented Apr 21, 2023

@satoshi-ota
Thanks for your support, I put the video of rtc in the description,

-> hmm, the video is missing.
todo: I will upload it again

@kosuke55
Copy link
Contributor Author

kosuke55 commented Apr 21, 2023

will run evaluator
->
tier4 internal scenario test 1323/1330

@kosuke55 kosuke55 force-pushed the feat/pull_out_avoidance branch 3 times, most recently from bd2c864 to e8ea2f6 Compare April 24, 2023 14:36
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the feat/pull_out_avoidance branch from e8ea2f6 to 375bb91 Compare April 25, 2023 02:18
Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 force-pushed the feat/pull_out_avoidance branch from df86783 to c49d0d2 Compare April 25, 2023 09:08
Mingyu1991 pushed a commit to Mingyu1991/autoware.universe that referenced this pull request Jun 26, 2023
autowarefoundation#3481)

* feat(behavior_path_planner): run avoidance and pull out simultaneously

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

* add ifdef for dirvable lanes

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

---------

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants