Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding switchable modes to LiDAR Visibility #345

Merged
merged 28 commits into from
Mar 3, 2022

Conversation

badai-nguyen
Copy link
Contributor

@badai-nguyen badai-nguyen commented Feb 7, 2022

Related Issue(required)

#357

Description(required)

This setup some options to exclude the effects of weak_first_return from objects:

  1. Checking point clouds of object segments in both directions: azimuth and rings
  2. Adding 3 switchable modes of region of interest (ROI):
  • Free-space ROI
  • Base_link based xyz-ROI
  • LiDAR based azimuth-distance-ROI

Review Procedure(required)

Switch and test 3 modes of ROI on a city road data.
Confirm the changing of visibility.

Related PR(optional)

tier4/aip_launcher#21

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

If you are adding new package following items are required:

  • Documentation with description of the package is available
  • A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR / build-and-test-pr: Required to pass before the merge.
  • Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the [guidelines][clang-tidy-guidelines].
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

badai-nguyen and others added 9 commits February 3, 2022 16:33
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Check normal pcl surrounding weak_first_return pcl to get free space.

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@codecov
Copy link

codecov bot commented Feb 7, 2022

Codecov Report

Merging #345 (7edd2cf) into tier4/proposal (637e981) will decrease coverage by 9.84%.
The diff coverage is 0.00%.

Impacted file tree graph

@@                Coverage Diff                @@
##           tier4/proposal    #345      +/-   ##
=================================================
- Coverage            9.84%   0.00%   -9.85%     
=================================================
  Files                 661      42     -619     
  Lines               47127    2862   -44265     
  Branches             5805       0    -5805     
=================================================
- Hits                 4641       0    -4641     
+ Misses              38622    2862   -35760     
+ Partials             3864       0    -3864     
Impacted Files Coverage Δ
...lier_filter/dual_return_outlier_filter_nodelet.cpp 0.00% <0.00%> (ø)
...ction_by_tracker/src/detection_by_tracker_core.cpp 0.00% <0.00%> (ø)
.../src/concatenate_data/concatenate_data_nodelet.cpp 0.00% <0.00%> (ø)
...src/outlier_filter/ring_outlier_filter_nodelet.cpp 0.00% <0.00%> (ø)
...l_based_approximate_compare_map_filter_nodelet.cpp 0.00% <0.00%> (ø)
...src/object_detection/predicted_objects_display.cpp
...ctor/src/external_velocity_limit_selector_node.cpp
...icle/raw_vehicle_cmd_converter/src/interpolate.cpp
...stacle_avoidance_planner/src/eb_path_optimizer.cpp
... and 615 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 637e981...7edd2cf. Read the comment docs.

Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
badai-nguyen and others added 2 commits February 8, 2022 09:38
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@miursh
Copy link
Contributor

miursh commented Feb 9, 2022

@badai-nguyen If you have made some change in launcher of this node, could you make another PR in launcher repository? And then attach the url to "Related PR(optional)" in this PR.

@badai-nguyen
Copy link
Contributor Author

@miursh Sure. I will create PR in aip launcher repo.

badai-nguyen and others added 2 commits February 18, 2022 14:56
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
@miursh
Copy link
Contributor

miursh commented Feb 26, 2022

@badai-nguyen Due to the source code change, https://github.com/autowarefoundation/autoware.universe/blob/tier4/proposal/sensing/pointcloud_preprocessor/docs/dual-return-outlier-filter.md needs to be modified.

@badai-nguyen badai-nguyen requested a review from miursh February 27, 2022 23:21
badai-nguyen and others added 4 commits February 28, 2022 13:47
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
badai-nguyen and others added 7 commits March 3, 2022 07:32
Co-authored-by: Shunsuke Miura <37187849+miursh@users.noreply.github.com>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Co-authored-by: Shunsuke Miura <37187849+miursh@users.noreply.github.com>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Co-authored-by: Shunsuke Miura <37187849+miursh@users.noreply.github.com>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Co-authored-by: Shunsuke Miura <37187849+miursh@users.noreply.github.com>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
miursh
miursh previously approved these changes Mar 3, 2022
@badai-nguyen badai-nguyen disabled auto-merge March 3, 2022 02:40
@badai-nguyen badai-nguyen changed the base branch from tier4/proposal to main March 3, 2022 03:26
@badai-nguyen badai-nguyen dismissed miursh’s stale review March 3, 2022 03:26

The base branch was changed.

@badai-nguyen badai-nguyen requested a review from miursh March 3, 2022 03:28
@badai-nguyen badai-nguyen enabled auto-merge (squash) March 3, 2022 03:29
@badai-nguyen badai-nguyen merged commit cf35622 into autowarefoundation:main Mar 3, 2022
@badai-nguyen badai-nguyen deleted the Vis_diag_v0.2 branch March 4, 2022 01:36
TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this pull request Oct 5, 2022
TomohitoAndo added a commit to TomohitoAndo/autoware.universe that referenced this pull request Oct 5, 2022
KYabuuchi pushed a commit to KYabuuchi/autoware.universe that referenced this pull request Feb 16, 2023
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
soblin pushed a commit to soblin/autoware.universe that referenced this pull request May 10, 2023
keiota pushed a commit to keiota/autoware.universe that referenced this pull request Aug 17, 2023
…ation#345)

* feat(autoware_launch): add marker of dynamic avoidance

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

* update

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>

---------

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
ryuichi-maeda pushed a commit to sensefield/autoware.universe that referenced this pull request Jan 10, 2025
Kazunori-Nakajima pushed a commit to Kazunori-Nakajima/autoware.universe that referenced this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants