-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding switchable modes to LiDAR Visibility #345
feat: adding switchable modes to LiDAR Visibility #345
Conversation
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Check normal pcl surrounding weak_first_return pcl to get free space. Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Codecov Report
@@ Coverage Diff @@
## tier4/proposal #345 +/- ##
=================================================
- Coverage 9.84% 0.00% -9.85%
=================================================
Files 661 42 -619
Lines 47127 2862 -44265
Branches 5805 0 -5805
=================================================
- Hits 4641 0 -4641
+ Misses 38622 2862 -35760
+ Partials 3864 0 -3864 Continue to review full report at Codecov.
|
5f174f0
to
11017f6
Compare
11017f6
to
7122a4c
Compare
b8905b8
to
8cec26f
Compare
@badai-nguyen If you have made some change in launcher of this node, could you make another PR in launcher repository? And then attach the url to "Related PR(optional)" in this PR. |
@miursh Sure. I will create PR in aip launcher repo. |
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
sensing/pointcloud_preprocessor/src/outlier_filter/dual_return_outlier_filter_nodelet.cpp
Outdated
Show resolved
Hide resolved
...cessor/include/pointcloud_preprocessor/outlier_filter/dual_return_outlier_filter_nodelet.hpp
Outdated
Show resolved
Hide resolved
sensing/pointcloud_preprocessor/src/outlier_filter/dual_return_outlier_filter_nodelet.cpp
Outdated
Show resolved
Hide resolved
sensing/pointcloud_preprocessor/src/outlier_filter/dual_return_outlier_filter_nodelet.cpp
Outdated
Show resolved
Hide resolved
sensing/pointcloud_preprocessor/src/outlier_filter/dual_return_outlier_filter_nodelet.cpp
Outdated
Show resolved
Hide resolved
@badai-nguyen Due to the source code change, https://github.com/autowarefoundation/autoware.universe/blob/tier4/proposal/sensing/pointcloud_preprocessor/docs/dual-return-outlier-filter.md needs to be modified. |
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
Signed-off-by: badai-nguyen <dai.nguyen@tier4.jp>
ab6ee0e
to
7edd2cf
Compare
…velop sync main for develop
chore: sync awf-latest
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
chore: sync upstream
…ation#345) * feat(autoware_launch): add marker of dynamic avoidance Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * update Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
chore: sync upstream
chore: sync awf-latest
Related Issue(required)
#357
Description(required)
This setup some options to exclude the effects of weak_first_return from objects:
Review Procedure(required)
Switch and test 3 modes of ROI on a city road data.
Confirm the changing of visibility.
Related PR(optional)
tier4/aip_launcher#21
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
If you are adding new package following items are required:
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks