fix(behavior_path_planner): fix updating pull out status for new architecture #3447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itecture Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3447 +/- ##
==========================================
- Coverage 13.25% 13.24% -0.01%
==========================================
Files 1384 1384
Lines 97016 97254 +238
Branches 28212 28375 +163
==========================================
+ Hits 12857 12879 +22
- Misses 70351 70536 +185
- Partials 13808 13839 +31
*This pull request uses carry forward flags. Click here to find out more.
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Mingyu1991
pushed a commit
to Mingyu1991/autoware.universe
that referenced
this pull request
Jun 26, 2023
…itecture (autowarefoundation#3447) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the bug that pull_out with the new architecture can not update the path before approval.
before approval, execute the following process in each loop
updating process is in
onEntryso the paths is not updated with new architecture.In this PR, move updating process to
planWaitingApprovalbefore PR
pull_out_back-2023-04-17_20.54.48.mp4
pull_out_back_new-2023-04-17_21.03.53.mp4
Related links
Tests performed
pull_out_back_old_after-2023-04-17_21.40.46.mp4
pull_out_back_new_after-2023-04-17_21.35.36.mp4
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.