Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(behavior_path_planner): pull over support road_lane and right_hand_traffic #3419

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

kosuke55
Copy link
Contributor

@kosuke55 kosuke55 commented Apr 14, 2023

Description

enhance pull over module

  • support road_lane

  • execute the module depending on allow_goal_modification of route msg

  • support right-hand traffic

    • select the policy with param (currently left_side and right_side)
    • but only support shit_pull_over and freespace_pull_over. not geometric_parallel_parking
  • pull_over is executed when

    • allow_goal_modification is true
    • putting goal in the shoulder_lane(temporary),
  • shoulder lane left (same to previous behavior)
    Screenshot from 2023-04-15 02-06-40

  • road lane left
    Screenshot from 2023-04-15 02-06-11

  • shoulder lane right

Screenshot from 2023-04-15 02-09-57

  • road lane right

Screenshot from 2023-04-15 02-12-38

  • lane change -> pull_over
goal_planner-2023-04-14_02.51.34.mp4

🤖 Generated by Copilot at 6d1cb87

This pull request enhances the pull over behavior of the behavior path planner by adding a parameter for parking policy, which allows the vehicle to park on either the left or right side of the road. It also refactors and improves the logic for goal search, path planning, and crossing check for pull over scenarios. Additionally, it updates the route handler and the mission planner to support goal modification based on the route option. It also includes some minor code cleanup and debugging changes.

Related links

PullOver/Out limitation and development plan

tier4 internal link

autowarefoundation/autoware_launch#300

Tests performed

psim
tier4 internal sceneario test

  • 152/152
    • pull_over 74/74
    • pull_out 78/78

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Apr 14, 2023
@kosuke55 kosuke55 force-pushed the feat/goal_module branch 3 times, most recently from 4be624a to 6747824 Compare April 14, 2023 15:53
@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Patch coverage: 11.90% and project coverage change: -0.09 ⚠️

Comparison is base (740754a) 13.25% compared to head (43ea020) 13.16%.

❗ Current head 43ea020 differs from pull request most recent head dc0d6a5. Consider uploading reports for the commit dc0d6a5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3419      +/-   ##
==========================================
- Coverage   13.25%   13.16%   -0.09%     
==========================================
  Files        1384     1384              
  Lines       97016    99255    +2239     
  Branches    28212    29676    +1464     
==========================================
+ Hits        12858    13071     +213     
- Misses      70351    72185    +1834     
- Partials    13807    13999     +192     
Flag Coverage Δ *Carryforward flag
differential 9.82% <11.90%> (?)
total 13.27% <ø> (+0.02%) ⬆️ Carriedforward from eea27d9

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...lanner/scene_module/pull_over/pull_over_module.hpp 75.00% <ø> (ø)
...th_planner/utils/pull_over/geometric_pull_over.hpp 0.00% <ø> (ø)
...r_path_planner/utils/pull_over/shift_pull_over.hpp 0.00% <ø> (ø)
...nner/include/behavior_path_planner/utils/utils.hpp 100.00% <ø> (ø)
...ic_parallel_parking/geometric_parallel_parking.cpp 0.00% <0.00%> (ø)
...lanner/src/utils/pull_over/geometric_pull_over.cpp 22.72% <0.00%> (ø)
...path_planner/src/utils/pull_over/goal_searcher.cpp 2.27% <0.00%> (-0.09%) ⬇️
planning/behavior_path_planner/src/utils/utils.cpp 20.16% <0.00%> (+0.59%) ⬆️
...on_planner/src/mission_planner/mission_planner.cpp 0.00% <0.00%> (ø)
...er/src/scene_module/pull_over/pull_over_module.cpp 7.96% <10.46%> (+0.57%) ⬆️
... and 4 more

... and 15 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kosuke55 kosuke55 force-pushed the feat/goal_module branch 2 times, most recently from af65be4 to ad8efd4 Compare April 17, 2023 02:30
Copy link
Contributor

@TakaHoribe TakaHoribe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed it worked as expected.

…nd_traffic

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
@kosuke55 kosuke55 merged commit ef0029d into main Apr 17, 2023
@kosuke55 kosuke55 deleted the feat/goal_module branch April 17, 2023 14:13
Mingyu1991 pushed a commit to Mingyu1991/autoware.universe that referenced this pull request Jun 26, 2023
…nd_traffic (autowarefoundation#3419)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants