-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(behavior_path_planner): pull over support road_lane and right_hand_traffic #3419
Conversation
6d1cb87
to
5cf01e3
Compare
4be624a
to
6747824
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3419 +/- ##
==========================================
- Coverage 13.25% 13.16% -0.09%
==========================================
Files 1384 1384
Lines 97016 99255 +2239
Branches 28212 29676 +1464
==========================================
+ Hits 12858 13071 +213
- Misses 70351 72185 +1834
- Partials 13807 13999 +192
*This pull request uses carry forward flags. Click here to find out more.
... and 15 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
af65be4
to
ad8efd4
Compare
ad8efd4
to
eea27d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed it worked as expected.
planning/behavior_path_planner/src/behavior_path_planner_node.cpp
Outdated
Show resolved
Hide resolved
43ea020
to
110424d
Compare
…nd_traffic Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
110424d
to
dc0d6a5
Compare
…nd_traffic (autowarefoundation#3419) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: Mingyu Li <mingyu.li@tier4.jp>
Description
enhance pull over module
support road_lane
execute the module depending on
allow_goal_modification
of route msgsupport right-hand traffic
shit_pull_over
andfreespace_pull_over
. notgeometric_parallel_parking
pull_over is executed when
allow_goal_modification
is true2D Rough Goal Pose
with rviz. the shortcut key isr
shoulder lane left (same to previous behavior)
![Screenshot from 2023-04-15 02-06-40](https://user-images.githubusercontent.com/39142679/232113751-40df2f87-f45d-4ed3-b5c6-ee6a035e4cc3.png)
road lane left
![Screenshot from 2023-04-15 02-06-11](https://user-images.githubusercontent.com/39142679/232113710-39d02980-009a-4a5e-bc3e-288321dd97e0.png)
shoulder lane right
goal_planner-2023-04-14_02.51.34.mp4
🤖 Generated by Copilot at 6d1cb87
This pull request enhances the pull over behavior of the behavior path planner by adding a parameter for parking policy, which allows the vehicle to park on either the left or right side of the road. It also refactors and improves the logic for goal search, path planning, and crossing check for pull over scenarios. Additionally, it updates the route handler and the mission planner to support goal modification based on the route option. It also includes some minor code cleanup and debugging changes.
Related links
PullOver/Out limitation and development plan
tier4 internal link
autowarefoundation/autoware_launch#300
Tests performed
psim
tier4 internal sceneario test
Notes for reviewers
Interface changes
Effects on system behavior
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.