fix(planner_manager): remove succeeded candidate module

[satoshi-ota]

Description

There are some modules that return ModuleStatus::SUCCESS before approval (e.g. pull over, avoidance), but planner_manager doesn't remove such a expired candidate module for now. Thus, these modules are never removed and next new module can't be launch depending on max_module_size value (all module set this param to 1 by default). As a result , an unexpected bahevior happend like this ⬇️

In this PR, the planner_manager removes not only ModuleStatus::FAILURE modules but also ModuleStatus::SUCCESS candidate modules.

simplescreenrecorder-2023-04-11_10.35.05.mp4

Tests performed

webauto ci scenario run --project-id prd_jt --scenario-id f112364c-1b55-4c48-bebd-8a68b0e52122 --runtime-path /$HOME/pilot-auto --scenario-parameters __tier4_modifier_Ve=11.111

simplescreenrecorder-2023-04-11_10.20.58.mp4

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

• I've confirmed the contribution guidelines.
• The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

• The PR follows the pull request guidelines.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

• There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

[satoshi-ota]

now, evaluator running...

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (93e040a) 12.33% compared to head (84fc9d1) 12.33%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3346   +/-   ##
=======================================
  Coverage   12.33%   12.33%           
=======================================
  Files        1381     1381           
  Lines       96692    96692           
  Branches    27978    27978           
=======================================
  Hits        11930    11930           
  Misses      72094    72094           
  Partials    12668    12668           

Flag	Coverage Δ		*Carryforward flag
differential	5.27% <0.00%> (?)
total	12.33% <ø> (+<0.01%)	⬆️	Carriedforward from 93e040a

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
...er/src/scene_module/avoidance/avoidance_module.cpp	0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[kosuke55]

thaks! good

[satoshi-ota]

Evaluator result: All pass pull over scenarios

1178/1200 -> 1197/1200