Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_control_launch): add check_external_emergency_heartbeat option #3079

Conversation

takayuki5168
Copy link
Contributor

@takayuki5168 takayuki5168 commented Mar 14, 2023

Description

add check_external_emergency_heartbeat option to designate it at runtime.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Mar 14, 2023
@takayuki5168 takayuki5168 marked this pull request as ready for review March 15, 2023 00:29
@takayuki5168 takayuki5168 requested review from TakaHoribe and a team as code owners March 15, 2023 00:29
@takayuki5168 takayuki5168 requested a review from h-ohta March 15, 2023 00:36
…tion

Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
@takayuki5168 takayuki5168 force-pushed the feat/add-check_external_emergency_heartbeat-option branch from 11cb30d to bb3eb50 Compare March 23, 2023 11:05
@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.41 ⚠️

Comparison is base (9d8c061) 12.32% compared to head (11cb30d) 11.91%.

❗ Current head 11cb30d differs from pull request most recent head bb3eb50. Consider uploading reports for the commit bb3eb50 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3079      +/-   ##
==========================================
- Coverage   12.32%   11.91%   -0.41%     
==========================================
  Files        1340     1332       -8     
  Lines       93409    92939     -470     
  Branches    26754    24737    -2017     
==========================================
- Hits        11512    11078     -434     
- Misses      69745    70381     +636     
+ Partials    12152    11480     -672     
Flag Coverage Δ *Carryforward flag
differential ∅ <ø> (?)
total 11.91% <ø> (-0.41%) ⬇️ Carriedforward from 5a0d672

*This pull request uses carry forward flags. Click here to find out more.

see 57 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@takayuki5168 takayuki5168 merged commit 75f99c7 into autowarefoundation:main Mar 23, 2023
@takayuki5168 takayuki5168 deleted the feat/add-check_external_emergency_heartbeat-option branch March 23, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants