Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dead link in autoware_auto_geometry README #2966

Closed
3 tasks done
satoshi-ota opened this issue Mar 1, 2023 · 8 comments · Fixed by #3077
Closed
3 tasks done

dead link in autoware_auto_geometry README #2966

satoshi-ota opened this issue Mar 1, 2023 · 8 comments · Fixed by #3077
Assignees
Labels
type:bug Software flaws or errors. type:documentation Creating or refining documentation. (auto-assigned)

Comments

@satoshi-ota
Copy link
Contributor

Checklist

  • I've read the contribution guidelines.
  • I've searched other issues and no duplicate issues were found.
  • I'm convinced that this is not my fault but a bug.

Description

Fow now, pre-commit optional outputs dead link error.

image

Expected behavior

pre-commit optional doesn't output dead link error in autoware_auto_geometry.

Actual behavior

pre-commit optional outputs dead link error in autoware_auto_geometry.

Steps to reproduce

  1. run pre-commit optional

NOTE: This error seems to be happend in github CI/CD only. (This error doesn't be reproduce in local environment.)

Versions

No response

Possible causes

No response

Additional context

No response

@satoshi-ota
Copy link
Contributor Author

satoshi-ota commented Mar 1, 2023

Hi @esteve
Thanks for your fix in #743, but unfortunately, pre-commit optional outputs dead link error, so could you fix it again?

Or, please tell me alternative links 🙏

@satoshi-ota satoshi-ota added type:bug Software flaws or errors. type:documentation Creating or refining documentation. (auto-assigned) labels Mar 1, 2023
@esteve
Copy link
Contributor

esteve commented Mar 14, 2023

@satoshi-ota can you point me to a GitHub CI run where this shows? Thanks for the screenshot, but unfortunately it does not have enough context and I'd prefer a link to a CI job. I checked the link locally and it resolves fine, I don't know what's wrong here.

@esteve
Copy link
Contributor

esteve commented Mar 14, 2023

@satoshi-ota I don't know much about that paper, I only updated the link in #743 The official link to that paper is the one we already have in Autoware.universe, so I don't know of any other source, if you find another link that works, please update #3077

I suspect that the link blocks access from GitHub, @kenji-miyake is there a way to avoid a link from being checked in the pre-commit script? Thanks.

@satoshi-ota
Copy link
Contributor Author

Hi @esteve Thanks for your work.

can you point me to a GitHub CI run where this shows?

Sorry for being unkind 🙏 The CI error can be seen in any opened PRs.
For example, your can see the error in #3079. Please click the Details button, and the error is going to be shown.

image

@satoshi-ota
Copy link
Contributor Author

I don't know much about that paper, I only updated the link in #743 The official link to that paper is the one we already have in Autoware.universe, so I don't know of any other source, if you find another link that works, please update #3077

I got it. Thanks, too.
I'll try to look for any other links, but I'm going to remove this link at the worst case.

@stale
Copy link

stale bot commented May 15, 2023

This pull request has been automatically marked as stale because it has not had recent activity.

@stale stale bot added the status:stale Inactive or outdated issues. (auto-assigned) label May 15, 2023
@esteve
Copy link
Contributor

esteve commented May 15, 2023

@satoshi-ota did you update/remove the link to the paper? Can this PR be closed? Thanks.

@stale stale bot removed the status:stale Inactive or outdated issues. (auto-assigned) label May 15, 2023
@satoshi-ota
Copy link
Contributor Author

Hi @esteve
Sorry, I fogot to remove the link. I remove it today in your PR #3077 🙏
And, I'll fix the other dead links.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Software flaws or errors. type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants