Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(traffic_ligtht_classifier): update document for CNN model customization #3037

Merged

Conversation

ktro2828
Copy link
Contributor

@ktro2828 ktro2828 commented Mar 9, 2023

Description

Currently, in autoware, we recommend to use open-mmlab/mmclassification for re-training CNN classifier.
Therefore I updated documents to train CNN models and apply them to traffic light cnn classifier node.
After this PR is merged, I will add the link of this document to the Autoware documentaion, as disscussed in this PR.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@ktro2828 ktro2828 requested review from miursh and Mingyu1991 March 9, 2023 03:43
@ktro2828 ktro2828 requested review from yukkysaito and a team as code owners March 9, 2023 03:43
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Mar 9, 2023
@ktro2828 ktro2828 force-pushed the docs/traffic-light-classifier branch from d371280 to 38eedbc Compare March 9, 2023 03:50
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7f064da) 11.93% compared to head (2be7592) 11.94%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3037   +/-   ##
=======================================
  Coverage   11.93%   11.94%           
=======================================
  Files        1321     1321           
  Lines       91936    91903   -33     
  Branches    24522    24511   -11     
=======================================
  Hits        10976    10976           
+ Misses      69602    69569   -33     
  Partials    11358    11358           
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 11.94% <ø> (+<0.01%) ⬆️ Carriedforward from 7f064da

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...havior_path_planner/behavior_path_planner_node.hpp 0.00% <ø> (ø)
...er/scene_module/lane_change/lane_change_module.hpp 0.00% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 0.14% <ø> (ø)
...rc/scene_module/lane_change/lane_change_module.cpp 0.00% <ø> (ø)
...erception/traffic_light_classifier/src/nodelet.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
@ktro2828 ktro2828 force-pushed the docs/traffic-light-classifier branch from 38eedbc to 2be7592 Compare March 9, 2023 05:40
@ktro2828 ktro2828 enabled auto-merge (squash) March 9, 2023 05:41
@ktro2828 ktro2828 merged commit 6a766ae into autowarefoundation:main Mar 9, 2023
@ktro2828 ktro2828 deleted the docs/traffic-light-classifier branch April 10, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants