fix(rtc_interface): fix initial auto mode #3029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
yabuta
approved these changes
Mar 8, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #3029 +/- ##
=======================================
Coverage 11.93% 11.93%
=======================================
Files 1321 1321
Lines 91941 91939 -2
Branches 24525 24525
=======================================
Hits 10977 10977
+ Misses 69607 69605 -2
Partials 11357 11357
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mkuri
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Mar 20, 2023
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
7 tasks
mkuri
added a commit
to tier4/autoware.universe
that referenced
this pull request
Mar 22, 2023
fix(rtc_interface): fix initial auto mode (autowarefoundation#3029)
xianglunkai
pushed a commit
to xianglunkai/autoware.universe
that referenced
this pull request
Apr 3, 2023
…ion#3029) * fix(ansible): fix installation step of git-lfs role Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp> * docs: update readme Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp> * Update ansible/roles/git_lfs/README.md Co-authored-by: M. Fatih Cırıt <xmfcx@users.noreply.github.com> * fix: change steps to pass CI Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp> Signed-off-by: yukke42 <yusuke.muramatsu@tier4.jp> Co-authored-by: M. Fatih Cırıt <xmfcx@users.noreply.github.com> Co-authored-by: Kenji Miyake <31987104+kenji-miyake@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this change, if
rtc_interfacereceives an auto mode service, it changes initial auto mode.This is not expected behavior.
Correct behavior is that initial auto mode will not be changed if rtc_interface` receives an auto mode service.
So, in this PR, I changed the code.
Furthermore, as the minor change, to clarify the meaning of
is_auto_mode_, I change the name tois_auto_mode_init_.Related links
Tests performed
TIER IV internal test was passed.
882/882
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.