-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(default_ad_api): add vehicle info api #2984
feat(default_ad_api): add vehicle info api #2984
Conversation
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
This pull request has been automatically marked as stale because it has not had recent activity. |
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2984 +/- ##
==========================================
- Coverage 14.43% 13.64% -0.80%
==========================================
Files 1462 1397 -65
Lines 102964 97057 -5907
Branches 29876 28777 -1099
==========================================
- Hits 14866 13245 -1621
+ Misses 71865 69480 -2385
+ Partials 16233 14332 -1901
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@isamu-takagi Is the usecase for this API shared somewhere? |
Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
The use cases are added in autowarefoundation/autoware-documentation#381. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Add vehicle dimension API.
Related links
Tests performed
ros2 service call /api/vehicle/info/dimensions autoware_adapi_v1_msgs/srv/GetVehicleDimensions
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.