-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(motion_velocity_smoother): improve velocity planning around stop point #2955
feat(motion_velocity_smoother): improve velocity planning around stop point #2955
Conversation
Signed-off-by: yutaka <purewater0901@gmail.com>
Codecov ReportBase: 11.52% // Head: 11.52% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2955 +/- ##
=======================================
Coverage 11.52% 11.52%
=======================================
Files 1314 1314
Lines 92794 92793 -1
Branches 24997 24998 +1
=======================================
Hits 10699 10699
+ Misses 70853 70852 -1
Partials 11242 11242
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
A little doubt about just removing this value. This PR allows using an infinite jerk when the reference velocity is zero. For example, in the case where
it is allowed for |
… point (autowarefoundation#2955) * feat(motion_velocity_smoother): remove unnecessary constant value Signed-off-by: yutaka <purewater0901@gmail.com> * update Signed-off-by: yutaka <purewater0901@gmail.com> --------- Signed-off-by: yutaka <purewater0901@gmail.com>
… point (autowarefoundation#2955) * feat(motion_velocity_smoother): remove unnecessary constant value Signed-off-by: yutaka <purewater0901@gmail.com> * update Signed-off-by: yutaka <purewater0901@gmail.com> --------- Signed-off-by: yutaka <purewater0901@gmail.com>
Description
Remove unnecessary constant values in the jerk-filtered optimization method.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.