Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(motion_velocity_smoother): improve velocity planning around stop point #2955

Merged
merged 2 commits into from
Feb 28, 2023

Conversation

purewater0901
Copy link
Contributor

@purewater0901 purewater0901 commented Feb 27, 2023

Description

Remove unnecessary constant values in the jerk-filtered optimization method.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: yutaka <purewater0901@gmail.com>
@purewater0901 purewater0901 requested review from rej55, mkuri, TakaHoribe and a team as code owners February 27, 2023 16:41
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 27, 2023
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Base: 11.52% // Head: 11.52% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (269742d) compared to base (b28d792).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2955   +/-   ##
=======================================
  Coverage   11.52%   11.52%           
=======================================
  Files        1314     1314           
  Lines       92794    92793    -1     
  Branches    24997    24998    +1     
=======================================
  Hits        10699    10699           
+ Misses      70853    70852    -1     
  Partials    11242    11242           
Flag Coverage Δ *Carryforward flag
differential 3.34% <0.00%> (?)
total 11.53% <ø> (+<0.01%) ⬆️ Carriedforward from 78bb154

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...y_smoother/src/smoother/jerk_filtered_smoother.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TakaHoribe
Copy link
Contributor

TakaHoribe commented Feb 28, 2023

A little doubt about just removing this value. This PR allows using an infinite jerk when the reference velocity is zero.

For example, in the case where v_ref[1]>0 and v_ref[2]=0, following the current constraints,

j_min[2] < (a[2] - a[1]) * v_ref[2] < j_max[2]

it is allowed for a[1] and a[2] to be defined without jerk constraint.

Signed-off-by: yutaka <purewater0901@gmail.com>
@purewater0901 purewater0901 changed the title feat(motion_velocity_smoother): remove unnecessary constant value feat(motion_velocity_smoother): improve velocity planning around stop point Feb 28, 2023
@purewater0901 purewater0901 merged commit 102d974 into autowarefoundation:main Feb 28, 2023
@purewater0901 purewater0901 deleted the feat/clean-jerk-smoother branch February 28, 2023 08:22
nabetetsu pushed a commit to xygyo77/autoware.universe that referenced this pull request Mar 1, 2023
… point (autowarefoundation#2955)

* feat(motion_velocity_smoother): remove unnecessary constant value

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

---------

Signed-off-by: yutaka <purewater0901@gmail.com>
1222-takeshi pushed a commit to 1222-takeshi/autoware.universe that referenced this pull request Mar 6, 2023
… point (autowarefoundation#2955)

* feat(motion_velocity_smoother): remove unnecessary constant value

Signed-off-by: yutaka <purewater0901@gmail.com>

* update

Signed-off-by: yutaka <purewater0901@gmail.com>

---------

Signed-off-by: yutaka <purewater0901@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants