fix(avoidance): avoidable right side parked-vehicle #2932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2932 +/- ##
==========================================
- Coverage 11.99% 11.99% -0.01%
==========================================
Files 1314 1314
Lines 91445 91474 +29
Branches 24240 24258 +18
==========================================
Hits 10971 10971
- Misses 69113 69142 +29
Partials 11361 11361
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Closed
4 tasks
3 tasks
1096415 to
76c14b0
Compare
|
@zulfaqar-azmi-t4 @mitsudome-r I fixed following issue, so could you review this PR? Thanks in advance 🙏 |
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
76c14b0 to
241d6e9
Compare
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
241d6e9 to
9a857c8
Compare
|
NOTE: ⬇️ This PR is no longer needed. |
|
Evaluator result [TIER IV INTERNAL LINK] Baseline 875/877 |
|
Tested with two map with difference lane width. It works nicely! |
1222-takeshi
pushed a commit
to 1222-takeshi/autoware.universe
that referenced
this pull request
Mar 6, 2023
…on#2932) * feat(route_handler): add getMostRightLanelet() Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * feat(avoidance): add new param to select right/left hand traffic Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(avoidance): support right hand traffic Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(avoidance): avoidable right side parked vehicle Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
⬇️ This must be merged before this PR.autowarefoundation/autoware_launch#223For now, part of the avoidance module's target filtering logic depends on left-hand traffic, so there is a issue that the ego could not avoid right side parked-vehicles in right-hand traffic environment.
In this PR, the avoidance module supports right-hand traffic, and it is able to avoid right side parked-vehicles.
Test perform
detect the left side stopped vehicle as parked car
detect the right side stopped vehicle as parked car
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.