Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(behavior_planning): replace generateUUID() with tier4_autoware_utils's function #2924

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Feb 21, 2023

Description

replace generateUUID() with tier4_autoware_utils's function

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

… in tier4 autoware utils

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…tion in tier4 autoware utils

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Feb 21, 2023
@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Base: 11.78% // Head: 12.58% // Increases project coverage by +0.79% 🎉

Coverage data is based on head (0dfc032) compared to base (e50dc49).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2924      +/-   ##
==========================================
+ Coverage   11.78%   12.58%   +0.79%     
==========================================
  Files        1324     1222     -102     
  Lines       92862    86990    -5872     
  Branches    25005    25005              
==========================================
  Hits        10944    10944              
+ Misses      70442    64572    -5870     
+ Partials    11476    11474       -2     
Flag Coverage Δ *Carryforward flag
differential 5.26% <0.00%> (?)
total 12.58% <ø> (+0.79%) ⬆️ Carriedforward from f070349

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...th_planner/scene_module/scene_module_interface.hpp 0.00% <ø> (ø)
...er/include/scene_module/scene_module_interface.hpp 0.00% <0.00%> (ø)
...planning_evaluator/src/planning_evaluator_node.cpp 34.37% <0.00%> (-2.09%) ⬇️
...erception/traffic_light_classifier/src/nodelet.cpp 0.00% <0.00%> (ø)
...enterpoint/postprocess/non_maximum_suppression.hpp
...rception/lidar_centerpoint/lib/centerpoint_trt.cpp
...t/include/lidar_centerpoint/centerpoint_config.hpp
...idar_apollo_instance_segmentation/src/detector.cpp
...r_centerpoint/lib/postprocess/circle_nms_kernel.cu
...nclude/traffic_light_classifier/cnn_classifier.hpp
... and 97 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kosuke55
Copy link
Contributor

just refactor?

@satoshi-ota
Copy link
Contributor Author

just refactor?

@kosuke55 YES!

@satoshi-ota satoshi-ota changed the title fix(behavior_planning): replace generateUUID() with tier4_autoware_utils's function refactor(behavior_planning): replace generateUUID() with tier4_autoware_utils's function Feb 21, 2023
Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota merged commit 902d3f9 into autowarefoundation:main Feb 22, 2023
@satoshi-ota satoshi-ota deleted the fix/replace-generate-uuid branch February 22, 2023 00:38
nabetetsu pushed a commit to xygyo77/autoware.universe that referenced this pull request Mar 1, 2023
…re_utils's function (autowarefoundation#2924)

* fix(behavior_path_planner): replace generateUUID() with util function in tier4 autoware utils

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(behavior_velocity_planner): replace generateUUID() with util function in tier4 autoware utils

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
1222-takeshi pushed a commit to 1222-takeshi/autoware.universe that referenced this pull request Mar 6, 2023
…re_utils's function (autowarefoundation#2924)

* fix(behavior_path_planner): replace generateUUID() with util function in tier4 autoware utils

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix(behavior_velocity_planner): replace generateUUID() with util function in tier4 autoware utils

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
xianglunkai pushed a commit to xianglunkai/autoware.universe that referenced this pull request Apr 3, 2023
…tion#2924)

Update to new docker tag

update according to the NVIDIA documentation as the old tag for the docker repository has been removed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants