-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(behavior_planning): replace generateUUID() with tier4_autoware_utils's function #2924
refactor(behavior_planning): replace generateUUID() with tier4_autoware_utils's function #2924
Conversation
… in tier4 autoware utils Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…tion in tier4 autoware utils Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Codecov ReportBase: 11.78% // Head: 12.58% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2924 +/- ##
==========================================
+ Coverage 11.78% 12.58% +0.79%
==========================================
Files 1324 1222 -102
Lines 92862 86990 -5872
Branches 25005 25005
==========================================
Hits 10944 10944
+ Misses 70442 64572 -5870
+ Partials 11476 11474 -2
*This pull request uses carry forward flags. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
just refactor? |
@kosuke55 YES! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…re_utils's function (autowarefoundation#2924) * fix(behavior_path_planner): replace generateUUID() with util function in tier4 autoware utils Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(behavior_velocity_planner): replace generateUUID() with util function in tier4 autoware utils Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…re_utils's function (autowarefoundation#2924) * fix(behavior_path_planner): replace generateUUID() with util function in tier4 autoware utils Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> * fix(behavior_velocity_planner): replace generateUUID() with util function in tier4 autoware utils Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com> --------- Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
…tion#2924) Update to new docker tag update according to the NVIDIA documentation as the old tag for the docker repository has been removed
Description
replace generateUUID() with tier4_autoware_utils's function
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.