-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(lane_change): only compute interpolate ego once #2839
perf(lane_change): only compute interpolate ego once #2839
Conversation
Codecov ReportBase: 11.53% // Head: 11.64% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2839 +/- ##
==========================================
+ Coverage 11.53% 11.64% +0.11%
==========================================
Files 1314 1314
Lines 92792 92802 +10
Branches 24996 25001 +5
==========================================
+ Hits 10699 10805 +106
+ Misses 70851 70661 -190
- Partials 11242 11336 +94
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
2c5d521
to
b9bb569
Compare
b9bb569
to
24dc70c
Compare
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
24dc70c
to
ffbefb9
Compare
…ion#2839) * fix(lane_change): improvement on isLaneChangePathSafe computation Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * re-add logic to ignore parked vehicle Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix the duration issues and some code editing Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
* fix(lane_change): extend target lane range in safety check (autowarefoundation#2776) * fix(lane_change): extend target lane range in safety check Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix both safety check in lane change module Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Refactoring Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * also made for external request Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * get all lanes within 100 meters Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Change logging level Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Fix target lane empty Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * check current pose Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fixed the wrong lane parameter Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix spell check Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * make code similar between lane change and external request Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix collision not working Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Rename parameters Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix remove some argument from function parameter Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * refactor(lane_change): compute obj indices return if safe path found (autowarefoundation#2825) Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * perf(lane_change): only compute interpolate ego once (autowarefoundation#2839) * fix(lane_change): improvement on isLaneChangePathSafe computation Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * re-add logic to ignore parked vehicle Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix the duration issues and some code editing Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…ion#2839) * fix(lane_change): improvement on isLaneChangePathSafe computation Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * re-add logic to ignore parked vehicle Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix the duration issues and some code editing Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
…ion#2839) * fix(lane_change): improvement on isLaneChangePathSafe computation Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * re-add logic to ignore parked vehicle Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix the duration issues and some code editing Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
* fix(lane_change): extend target lane range in safety check (autowarefoundation#2776) * fix(lane_change): extend target lane range in safety check Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix both safety check in lane change module Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Refactoring Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * also made for external request Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * get all lanes within 100 meters Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Change logging level Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Fix target lane empty Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * check current pose Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fixed the wrong lane parameter Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix spell check Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * make code similar between lane change and external request Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix collision not working Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * Rename parameters Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix remove some argument from function parameter Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * refactor(lane_change): compute obj indices return if safe path found (autowarefoundation#2825) Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * perf(lane_change): only compute interpolate ego once (autowarefoundation#2839) * fix(lane_change): improvement on isLaneChangePathSafe computation Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * re-add logic to ignore parked vehicle Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> * fix the duration issues and some code editing Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> --------- Signed-off-by: Muhammad Zulfaqar Azmi <zulfaqar.azmi@tier4.jp> Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp> Co-authored-by: Zulfaqar Azmi <93502286+zulfaqar-azmi-t4@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Description
Related to increasing performance of lane change module.
At the moment, ego pose and polyon is interpolated against its predicted path during safety check, together with target object. but this is unnecessary, as ego path can be interpolated only once.
To solve this, I have extracted ego pose and polygon computation so that it only computed once.
Related links
#2825
Tests performed
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.