feat(intersection): add param for stuck stopline overshoot margin #2756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
This was referenced Jan 27, 2023
Codecov ReportBase: 11.64% // Head: 11.61% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2756 +/- ##
==========================================
- Coverage 11.64% 11.61% -0.03%
==========================================
Files 1312 1312
Lines 91448 91643 +195
Branches 24343 24483 +140
==========================================
Hits 10648 10648
- Misses 69685 69856 +171
- Partials 11115 11139 +24
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
maxime-clem
pushed a commit
to maxime-clem/autoware.universe
that referenced
this pull request
Jan 30, 2023
…towarefoundation#2756) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
lexavtanke
pushed a commit
to lexavtanke/autoware.universe
that referenced
this pull request
Jan 31, 2023
…towarefoundation#2756) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp> Signed-off-by: Alexey Panferov <lexavtanke@gmail.com>
soblin
added a commit
to tier4/autoware.universe
that referenced
this pull request
Feb 7, 2023
…towarefoundation#2756) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
asana17
pushed a commit
to asana17/autoware.universe
that referenced
this pull request
Feb 8, 2023
…towarefoundation#2756) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
soblin
added a commit
to soblin/autoware.universe
that referenced
this pull request
May 7, 2023
…towarefoundation#2756) Signed-off-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mamoru Sobue mamoru.sobue@tier4.jp
Description
Add param for the overshoot from stuck stop line that was previously hardcoded
Related links
parameter PR to awf: https://github.com/autowarefoundation/autoware_launch/pull/188/files
parameter PR to awf: tier4/autoware_launch#738
Tests performed
This cases turns successful
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.