Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(motion_utils): delete calcSignedArcLength with threshold #2742

Conversation

kyoichi-sugahara
Copy link
Contributor

@kyoichi-sugahara kyoichi-sugahara commented Jan 25, 2023

Description

delete calcSignedArcLength with distance/yaw threshold

  • find nearest idx/segment with distance/yaw threshold in afvance

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.

In-review checklist for the PR reviewers

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
    After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@github-actions github-actions bot added component:common Common packages from the autoware-common repository. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Jan 25, 2023
kyoichi-sugahara and others added 11 commits January 26, 2023 15:12
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
…eshold

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@kyoichi-sugahara kyoichi-sugahara changed the title Refactor/delete calcSignedArcLength with threshold refactor(motion_utils): delete calcSignedArcLength with threshold Feb 22, 2023
@kyoichi-sugahara kyoichi-sugahara marked this pull request as ready for review February 22, 2023 09:28
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Patch coverage: 22.22% and project coverage change: -0.01 ⚠️

Comparison is base (9929414) 12.80% compared to head (3385fc5) 12.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2742      +/-   ##
==========================================
- Coverage   12.80%   12.79%   -0.01%     
==========================================
  Files        1213     1213              
  Lines       85652    85638      -14     
  Branches    24277    24276       -1     
==========================================
- Hits        10970    10960      -10     
- Misses      63320    63323       +3     
+ Partials    11362    11355       -7     
Flag Coverage Δ *Carryforward flag
differential 13.81% <22.22%> (?)
total 12.78% <ø> (-0.02%) ⬇️ Carriedforward from 9929414

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...tion_utils/test/src/trajectory/test_trajectory.cpp 25.35% <ø> (-0.15%) ⬇️
...er/src/scene_module/pull_over/pull_over_module.cpp 0.00% <0.00%> (ø)
...city_planner/src/scene_module/blind_spot/scene.cpp 0.00% <0.00%> (ø)
...ene_module/occlusion_spot/scene_occlusion_spot.cpp 0.00% <0.00%> (ø)
...ation_based_planner/optimization_based_planner.cpp 0.00% <0.00%> (ø)
.../obstacle_cruise_planner/src/planner_interface.cpp 0.00% <0.00%> (ø)
...ils/include/motion_utils/trajectory/trajectory.hpp 75.87% <85.71%> (+0.74%) ⬆️
...planning_evaluator/src/planning_evaluator_node.cpp 36.45% <0.00%> (+2.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyoichi-sugahara kyoichi-sugahara enabled auto-merge (squash) March 3, 2023 06:33
@kyoichi-sugahara kyoichi-sugahara merged commit 9dd2100 into autowarefoundation:main Mar 3, 2023
1222-takeshi pushed a commit to 1222-takeshi/autoware.universe that referenced this pull request Mar 6, 2023
…towarefoundation#2742)

* delete calcSignedArcLength_with_threshold

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* delete calcSignedArcLength_with_threshold

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* replace called calcSignedArcLength_with_threshold

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* temp

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* add calcSignedArcLength without threshould

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* add calcSignedArcLength without threshould

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* modify code in obstacle_cruise_planner

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* style(pre-commit): autofix

* modify code in behavior_path_planner

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* modify code in behavior_velocity_planner

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* style(pre-commit): autofix

* fixed code

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* fixed code

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* style(pre-commit): autofix

* add check in case of no segment index found

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@kyoichi-sugahara kyoichi-sugahara deleted the refactor/delete_calcSignedArcLength_with_threshold branch April 15, 2023 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants