-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(motion_utils): delete calcSignedArcLength with threshold #2742
refactor(motion_utils): delete calcSignedArcLength with threshold #2742
Conversation
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
…dArcLength_with_threshold
…eshold Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
…dArcLength_with_threshold
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
common/motion_utils/include/motion_utils/trajectory/trajectory.hpp
Outdated
Show resolved
Hide resolved
common/motion_utils/include/motion_utils/trajectory/trajectory.hpp
Outdated
Show resolved
Hide resolved
common/motion_utils/include/motion_utils/trajectory/trajectory.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2742 +/- ##
==========================================
- Coverage 12.80% 12.79% -0.01%
==========================================
Files 1213 1213
Lines 85652 85638 -14
Branches 24277 24276 -1
==========================================
- Hits 10970 10960 -10
- Misses 63320 63323 +3
+ Partials 11362 11355 -7
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
planning/obstacle_cruise_planner/src/optimization_based_planner/optimization_based_planner.cpp
Outdated
Show resolved
Hide resolved
planning/obstacle_cruise_planner/src/optimization_based_planner/optimization_based_planner.cpp
Outdated
Show resolved
Hide resolved
…dArcLength_with_threshold
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp
Show resolved
Hide resolved
planning/behavior_path_planner/src/scene_module/pull_over/pull_over_module.cpp
Show resolved
Hide resolved
planning/behavior_velocity_planner/src/scene_module/blind_spot/scene.cpp
Show resolved
Hide resolved
planning/behavior_velocity_planner/src/scene_module/occlusion_spot/scene_occlusion_spot.cpp
Show resolved
Hide resolved
…dArcLength_with_threshold
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
…towarefoundation#2742) * delete calcSignedArcLength_with_threshold Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * delete calcSignedArcLength_with_threshold Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * replace called calcSignedArcLength_with_threshold Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * temp Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * add calcSignedArcLength without threshould Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * add calcSignedArcLength without threshould Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * modify code in obstacle_cruise_planner Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * style(pre-commit): autofix * modify code in behavior_path_planner Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * modify code in behavior_velocity_planner Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * style(pre-commit): autofix * fixed code Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * fixed code Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * style(pre-commit): autofix * add check in case of no segment index found Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Description
delete calcSignedArcLength with distance/yaw threshold
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
I've confirmed the contribution guidelines.
The PR follows the pull request guidelines.
In-review checklist for the PR reviewers
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.