-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(behavior_path_planner): apply resampling with spline around a goal pose #2411
Conversation
…l pose Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
Codecov ReportBase: 10.47% // Head: 10.47% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2411 +/- ##
==========================================
- Coverage 10.47% 10.47% -0.01%
==========================================
Files 1248 1248
Lines 91319 91346 +27
Branches 21044 21069 +25
==========================================
Hits 9565 9565
- Misses 71567 71590 +23
- Partials 10187 10191 +4
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…l pose (autowarefoundation#2411) Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
…l pose (autowarefoundation#2411) Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
…l pose (autowarefoundation#2411) Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com> Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: Makoto Kurihara mkuri8m@gmail.com
Description
Because the path near the goal point is sparse, it's not possible to determine the proper pose when inserting a new point near the goal point.
Resample with spline completion will be also applied near the goal.
Before
![Screenshot from 2022-11-30 23-23-15](https://user-images.githubusercontent.com/876355/204822295-32b85bdb-139c-45e6-924f-7f82e9729560.png)
After
![Screenshot from 2022-11-30 23-15-51](https://user-images.githubusercontent.com/876355/204822323-8294e88c-e9e8-47eb-bfaf-a34185b0f08a.png)
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.