Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior_path_planner): apply resampling with spline around a goal pose #2411

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

mkuri
Copy link
Contributor

@mkuri mkuri commented Nov 30, 2022

Signed-off-by: Makoto Kurihara mkuri8m@gmail.com

Description

Because the path near the goal point is sparse, it's not possible to determine the proper pose when inserting a new point near the goal point.
Resample with spline completion will be also applied near the goal.

Before
Screenshot from 2022-11-30 23-23-15

After
Screenshot from 2022-11-30 23-15-51

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…l pose

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Nov 30, 2022
@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Base: 10.47% // Head: 10.47% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (4c92de2) compared to base (a85643f).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2411      +/-   ##
==========================================
- Coverage   10.47%   10.47%   -0.01%     
==========================================
  Files        1248     1248              
  Lines       91319    91346      +27     
  Branches    21044    21069      +25     
==========================================
  Hits         9565     9565              
- Misses      71567    71590      +23     
- Partials    10187    10191       +4     
Flag Coverage Δ *Carryforward flag
differential 3.18% <0.00%> (?)
total 10.45% <0.00%> (ø) Carriedforward from a85643f

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...or_path_planner/src/behavior_path_planner_node.cpp 0.18% <0.00%> (-0.01%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkuri mkuri merged commit a7270a8 into autowarefoundation:main Dec 1, 2022
TomohitoAndo pushed a commit to tier4/autoware.universe that referenced this pull request Dec 2, 2022
…l pose (autowarefoundation#2411)

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
…l pose (autowarefoundation#2411)

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
…l pose (autowarefoundation#2411)

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>

Signed-off-by: Makoto Kurihara <mkuri8m@gmail.com>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants