Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(behavior velocity planner): occlusion spot slice #237

Conversation

taikitanaka3
Copy link
Contributor

@taikitanaka3 taikitanaka3 commented Jan 7, 2022

Related Issue(required)

merge after tier4/autoware_launch-old#164 solved

Description(required)

fix slice shape won't be correct where lateral max distance to see is larger than 1/curvature.

from to

this is because offsetNoThrow function in lanelet2 create new linestring and additional point to offset linestring at joinSubstring and this means creating discrete offset polygon needs additional search of find closet at each offset linestring.

To solve, add "closest search linestring while creating polygon from, linestring"(too heavy) or "create geometric offset" linestring(this can causes inversion but in this module there is no problem for inversion because there is process of sorting each polygon by minimum arclength after this)

also since logitudinal offset is less interesting than lateral offset and to reduce computational cost combine slice polygon longitudinally.

This PR is irrelevant to spline interpolation becomes linear at curve that starts from closest point to ego and this fix will be in another PR

TODO in another PR:
consider path point including behind ego too and make pair of interest instead of trimming path.
Original path (received by the OccludedSpot module)

trim_path (modified to only contain the relevant part of the path).

Interpolated path

Review Procedure(required)

Psim
launch psim using autoware.proj
get kashiwanoha map or "some maps that includes private tag" from fms https://tools.tier4.jp/vector_map_builder_ll2/
enable sidewalk marker in Rviz
image
see autoware drives normally with webcontroller
http://localhost:8085/web_controller/index.html
image

Related PR(optional)

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

If you are adding new package following items are required:

  • Documentation with description of the package is available
  • A sample launch file and parameter file are available if the package contains executable nodes

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR / build-and-test-pr: Required to pass before the merge.
  • Build and test for PR / clang-tidy-pr: NOT required to pass before the merge. It is up to the reviewer(s). Found false positives? See the [guidelines][clang-tidy-guidelines].
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@taikitanaka3
Copy link
Contributor Author

@maxime-clem
can you take a look at?

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
@taikitanaka3 taikitanaka3 force-pushed the fix-behavior-velocity-planner-occlusion-spot-slice branch 2 times, most recently from 8ed8480 to 2323643 Compare January 13, 2022 12:38
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
@taikitanaka3 taikitanaka3 force-pushed the fix-behavior-velocity-planner-occlusion-spot-slice branch from d3d3881 to dd160e3 Compare January 14, 2022 09:52
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
@tkimura4 tkimura4 self-requested a review January 14, 2022 10:18
@taikitanaka3 taikitanaka3 marked this pull request as ready for review January 14, 2022 10:35
@tkimura4
Copy link
Contributor

Before
image
After
image

Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taikitanaka3 taikitanaka3 merged commit 2b1c1b3 into autowarefoundation:tier4/proposal Jan 17, 2022
TomohitoAndo referenced this pull request in tier4/autoware.universe Jan 29, 2022
* fix: occlusion spot slice

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore: use to path lanelet

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix: pre-commit

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore: minor change for debug and test

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix(gtest): update to latest and minor fix of edge case

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(typo): fix typo

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Feb 4, 2022
…ion#237)

* fix: occlusion spot slice

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore: use to path lanelet

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix: pre-commit

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore: minor change for debug and test

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix(gtest): update to latest and minor fix of edge case

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(typo): fix typo

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Feb 4, 2022
…ion#237)

* fix: occlusion spot slice

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore: use to path lanelet

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix: pre-commit

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore: minor change for debug and test

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix(gtest): update to latest and minor fix of edge case

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(typo): fix typo

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
taikitanaka3 referenced this pull request in tier4/autoware.universe Feb 18, 2022
* fix: occlusion spot slice

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore: use to path lanelet

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix: pre-commit

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore: minor change for debug and test

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix(gtest): update to latest and minor fix of edge case

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(typo): fix typo

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
@taikitanaka3 taikitanaka3 deleted the fix-behavior-velocity-planner-occlusion-spot-slice branch April 13, 2022 09:55
satoshi-ota pushed a commit to satoshi-ota/autoware.universe that referenced this pull request May 20, 2022
…ion#237)

* fix: occlusion spot slice

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore: use to path lanelet

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix: pre-commit

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore: minor change for debug and test

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* fix(gtest): update to latest and minor fix of edge case

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>

* chore(typo): fix typo

Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this pull request Oct 5, 2022
TomohitoAndo pushed a commit to TomohitoAndo/autoware.universe that referenced this pull request Oct 5, 2022
Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
shmpwk pushed a commit to shmpwk/autoware.universe that referenced this pull request Jan 9, 2023
…round the goal (autowarefoundation#2617) (autowarefoundation#237)

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>

Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
keiota pushed a commit to keiota/autoware.universe that referenced this pull request Aug 17, 2023
feat(behavior_path_planner): add config for pull over on new framework

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants