-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(behavior velocity planner): occlusion spot slice #237
Merged
taikitanaka3
merged 6 commits into
autowarefoundation:tier4/proposal
from
taikitanaka3:fix-behavior-velocity-planner-occlusion-spot-slice
Jan 17, 2022
Merged
fix(behavior velocity planner): occlusion spot slice #237
taikitanaka3
merged 6 commits into
autowarefoundation:tier4/proposal
from
taikitanaka3:fix-behavior-velocity-planner-occlusion-spot-slice
Jan 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@maxime-clem |
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
8ed8480
to
2323643
Compare
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
d3d3881
to
dd160e3
Compare
Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
tkimura4
approved these changes
Jan 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TomohitoAndo
referenced
this pull request
in tier4/autoware.universe
Jan 29, 2022
* fix: occlusion spot slice Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore: use to path lanelet Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * fix: pre-commit Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore: minor change for debug and test Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * fix(gtest): update to latest and minor fix of edge case Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore(typo): fix typo Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
badai-nguyen
pushed a commit
to badai-nguyen/autoware.universe
that referenced
this pull request
Feb 4, 2022
…ion#237) * fix: occlusion spot slice Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore: use to path lanelet Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * fix: pre-commit Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore: minor change for debug and test Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * fix(gtest): update to latest and minor fix of edge case Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore(typo): fix typo Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
badai-nguyen
pushed a commit
to badai-nguyen/autoware.universe
that referenced
this pull request
Feb 4, 2022
…ion#237) * fix: occlusion spot slice Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore: use to path lanelet Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * fix: pre-commit Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore: minor change for debug and test Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * fix(gtest): update to latest and minor fix of edge case Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore(typo): fix typo Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
7 tasks
taikitanaka3
referenced
this pull request
in tier4/autoware.universe
Feb 18, 2022
* fix: occlusion spot slice Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore: use to path lanelet Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * fix: pre-commit Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore: minor change for debug and test Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * fix(gtest): update to latest and minor fix of edge case Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore(typo): fix typo Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
satoshi-ota
pushed a commit
to satoshi-ota/autoware.universe
that referenced
this pull request
May 20, 2022
…ion#237) * fix: occlusion spot slice Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore: use to path lanelet Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * fix: pre-commit Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore: minor change for debug and test Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * fix(gtest): update to latest and minor fix of edge case Signed-off-by: tanaka3 <ttatcoder@outlook.jp> * chore(typo): fix typo Signed-off-by: tanaka3 <ttatcoder@outlook.jp>
TomohitoAndo
pushed a commit
to TomohitoAndo/autoware.universe
that referenced
this pull request
Oct 5, 2022
TomohitoAndo
pushed a commit
to TomohitoAndo/autoware.universe
that referenced
this pull request
Oct 5, 2022
Signed-off-by: Yukihiro Saito <yukky.saito@gmail.com>
shmpwk
pushed a commit
to shmpwk/autoware.universe
that referenced
this pull request
Jan 9, 2023
…round the goal (autowarefoundation#2617) (autowarefoundation#237) Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com> Signed-off-by: kosuke55 <kosuke.tnp@gmail.com>
keiota
pushed a commit
to keiota/autoware.universe
that referenced
this pull request
Aug 17, 2023
feat(behavior_path_planner): add config for pull over on new framework Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(required)
merge after tier4/autoware_launch-old#164 solved
Description(required)
fix slice shape won't be correct where lateral max distance to see is larger than 1/curvature.
from
to ![](https://user-images.githubusercontent.com/65527974/148375902-c6cf07f0-b6b3-4225-a00d-15ef668c5a3a.png)
this is because offsetNoThrow function in lanelet2 create new linestring and additional point to offset linestring at joinSubstring and this means creating discrete offset polygon needs additional search of find closet at each offset linestring.
To solve, add "closest search linestring while creating polygon from, linestring"(too heavy) or "create geometric offset" linestring(this can causes inversion but in this module there is no problem for inversion because there is process of sorting each polygon by minimum arclength after this)
also since logitudinal offset is less interesting than lateral offset and to reduce computational cost combine slice polygon longitudinally.
This PR is irrelevant to spline interpolation becomes linear at curve that starts from closest point to ego and this fix will be in another PR
TODO in another PR:
![](https://user-images.githubusercontent.com/78338830/149295526-7b0b17c0-b664-4f69-9381-9f384db255b1.png)
![](https://user-images.githubusercontent.com/78338830/149295542-08146e9d-747b-4eab-80e3-cb5e488d2032.png)
![](https://user-images.githubusercontent.com/78338830/149295542-08146e9d-747b-4eab-80e3-cb5e488d2032.png)
consider path point including behind ego too and make pair of interest instead of trimming path.
Original path (received by the OccludedSpot module)
trim_path (modified to only contain the relevant part of the path).
Interpolated path
Review Procedure(required)
Psim
![image](https://user-images.githubusercontent.com/65527974/149494979-cdce14c9-1e12-4ba9-b1a7-c925fb9959ac.png)
![image](https://user-images.githubusercontent.com/65527974/149494691-c1039049-9eb4-4f8c-a3cf-ee865027f2f4.png)
launch psim using autoware.proj
get kashiwanoha map or "some maps that includes private tag" from fms https://tools.tier4.jp/vector_map_builder_ll2/
enable sidewalk marker in Rviz
see autoware drives normally with webcontroller
http://localhost:8085/web_controller/index.html
Related PR(optional)
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
If you are adding new package following items are required:
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks