Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(map_loader): modularization #2243

Merged
merged 12 commits into from
Nov 9, 2022
Merged

refactor(map_loader): modularization #2243

merged 12 commits into from
Nov 9, 2022

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Nov 8, 2022 •
edited
Loading

Signed-off-by: kminoda koji.minoda@tier4.jp

Description

Final goal: to merge #1938

I would like to add a new functionality in pointcloud_map_loader, and as a first step, I want to refactor the current implementation so that the further implementation would be easier to evaluate

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

kminoda and others added 8 commits November 8, 2022 14:47
@kminoda
refactor(map_loader): modularization
b6b22b1 
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@pre-commit-ci
ci(pre-commit): autofix
aa55902
@kminoda
simplified
68df904 
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda
Merge branch 'refactor/map_loader/modularization' of github.com:kmino…
c93d955 
…da/autoware.universe into refactor/map_loader/modularization
@kminoda
removed autoware_msgs dependency (not yet necessary at this moment)
7d9c12d 
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@pre-commit-ci
ci(pre-commit): autofix
dd39b40
@kminoda
remove unnecessary changes
17abf31 
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda
Merge branch 'refactor/map_loader/modularization' of github.com:kmino…
77050c9 
…da/autoware.universe into refactor/map_loader/modularization
@kminoda kminoda marked this pull request as ready for review November 8, 2022 06:00
kminoda and others added 2 commits November 8, 2022 15:02
@kminoda
pre-commit
5462bf1 
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@pre-commit-ci
ci(pre-commit): autofix
56ae962
@kminoda
Copy link
Contributor Author

kminoda commented Nov 8, 2022

@kenji-miyake @mitsudome-r This is the first PR I would like you to review to integrate the dynamic map loading in Autoware.
(Sorry for making multiple PRs and going back-and-forward between draft and ready-for-review)

@kminoda kminoda self-assigned this Nov 8, 2022
@kminoda kminoda added the component:map Map creation, storage, and loading. (auto-assigned) label Nov 8, 2022
@kenji-miyake
Copy link
Contributor

@kminoda Thank you. I think you can add your team members (and you can remove me anymore) to the maintainers and get their review to merge this PR.

@kminoda kminoda requested a review from RyuYamamoto November 8, 2022 08:40
@kminoda
edit copyright
223d8cd 
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda
Merge branch 'refactor/map_loader/modularization' of github.com:kmino…
db0d7e3 
…da/autoware.universe into refactor/map_loader/modularization
@codecov
Copy link

codecov bot commented Nov 8, 2022 •
edited
Loading

Codecov Report

Base: 11.15% // Head: 11.14% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (db0d7e3) compared to base (a1adc88).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2243      +/-   ##
==========================================
- Coverage   11.15%   11.14%   -0.01%     
==========================================
  Files        1200     1201       +1     
  Lines       86183    86226      +43     
  Branches    20786    20786              
==========================================
  Hits         9614     9614              
- Misses      66442    66485      +43     
  Partials    10127    10127
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 11.12% <0.00%> (ø) Carriedforward from a1adc88

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...tcloud_map_loader/pointcloud_map_loader_module.cpp 0.00% <0.00%> (ø)
...intcloud_map_loader/pointcloud_map_loader_node.cpp 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

RyuYamamoto
RyuYamamoto approved these changes Nov 9, 2022
View reviewed changes
Copy link
Contributor

@RyuYamamoto RyuYamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kminoda kminoda merged commit 8f8ec9d into autowarefoundation:main Nov 9, 2022
@kminoda kminoda deleted the refactor/map_loader/modularization branch December 13, 2022 00:20
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
@kminoda @pre-commit-ci @HansRobo
refactor(map_loader): modularization (autowarefoundation#2243)
e4b7367 
* refactor(map_loader): modularization

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* simplified

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* removed autoware_msgs dependency (not yet necessary at this moment)

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* remove unnecessary changes

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* pre-commit

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* edit copyright

Signed-off-by: kminoda <koji.minoda@tier4.jp>

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
YoshiRi pushed a commit to YoshiRi/autoware.universe that referenced this pull request Jan 11, 2023
@kminoda @pre-commit-ci @YoshiRi
refactor(map_loader): modularization (autowarefoundation#2243)
f2432e9 
* refactor(map_loader): modularization

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* simplified

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* removed autoware_msgs dependency (not yet necessary at this moment)

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* remove unnecessary changes

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* pre-commit

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* edit copyright

Signed-off-by: kminoda <koji.minoda@tier4.jp>

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: yoshiri <yoshiyoshidetteiu@gmail.com>
h-ohta pushed a commit to tier4/autoware.universe that referenced this pull request Jan 26, 2023
@kminoda @pre-commit-ci @h-ohta
refactor(map_loader): modularization (autowarefoundation#2243)
4709a84 
* refactor(map_loader): modularization

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* simplified

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* removed autoware_msgs dependency (not yet necessary at this moment)

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* remove unnecessary changes

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* pre-commit

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* edit copyright

Signed-off-by: kminoda <koji.minoda@tier4.jp>

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
h-ohta pushed a commit to tier4/autoware.universe that referenced this pull request Jan 26, 2023
@kminoda @pre-commit-ci @h-ohta
refactor(map_loader): modularization (autowarefoundation#2243)
fff7d2a 
* refactor(map_loader): modularization

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* simplified

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* removed autoware_msgs dependency (not yet necessary at this moment)

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* remove unnecessary changes

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* pre-commit

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* edit copyright

Signed-off-by: kminoda <koji.minoda@tier4.jp>

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
h-ohta pushed a commit to tier4/autoware.universe that referenced this pull request Jan 26, 2023
@kminoda @pre-commit-ci @h-ohta
refactor(map_loader): modularization (autowarefoundation#2243)
2d60ae8 
* refactor(map_loader): modularization

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* simplified

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* removed autoware_msgs dependency (not yet necessary at this moment)

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* remove unnecessary changes

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* pre-commit

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* edit copyright

Signed-off-by: kminoda <koji.minoda@tier4.jp>

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
h-ohta pushed a commit to tier4/autoware.universe that referenced this pull request Jan 27, 2023
@kminoda @pre-commit-ci @h-ohta
refactor(map_loader): modularization (autowarefoundation#2243)
b76cbd8 
* refactor(map_loader): modularization

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* simplified

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* removed autoware_msgs dependency (not yet necessary at this moment)

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* remove unnecessary changes

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* pre-commit

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* edit copyright

Signed-off-by: kminoda <koji.minoda@tier4.jp>

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RyuYamamoto RyuYamamoto RyuYamamoto approved these changes

@kenji-miyake kenji-miyake Awaiting requested review from kenji-miyake

@mitsudome-r mitsudome-r Awaiting requested review from mitsudome-r

Assignees

@kminoda kminoda

Labels
component:map Map creation, storage, and loading. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kminoda @kenji-miyake @RyuYamamoto