Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(map_loader): add partial map loading interface in pointcloud_map_loader #1938

Merged
merged 63 commits into from
Dec 1, 2022
Merged

feat(map_loader): add partial map loading interface in pointcloud_map_loader #1938

merged 63 commits into from
Dec 1, 2022

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Sep 22, 2022 •
edited
Loading

Signed-off-by: kminoda koji.minoda@tier4.jp

Description

I would like to add a new functionality for some new map loading features in pointcloud_map_loader.
See https://github.com/orgs/autowarefoundation/discussions/2812 for overall idea.
See https://github.com/autowarefoundation/autoware_msgs/tree/main/autoware_map_msgs for the details of each interface.

Note: I will create another PR for differential_map_loading, as it will contain some similar implementation as partial_map_loading.

Related links

Tests performed

Notes for reviewers

This PR should not have any effect on the current interface (just adding a new interface)

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kminoda
first commit
ca46285 
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda
reverted unnecessary modification
adbc19c 
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda kminoda self-assigned this Sep 22, 2022
@kminoda kminoda added the component:map Map creation, storage, and loading. (auto-assigned) label Sep 22, 2022
pre-commit-ci bot and others added 4 commits September 22, 2022 09:58
@pre-commit-ci
ci(pre-commit): autofix
f5eecae
@kminoda
renamed some classes
7ec5690 
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@pre-commit-ci
ci(pre-commit): autofix
c4d20e5
@kminoda
move autoware_map_msgs to autoware_msgs repos
4b97e86 
Signed-off-by: kminoda <koji.m.minoda@gmail.com>
@kminoda kminoda mentioned this pull request Sep 28, 2022
Merged
7 tasks
kminoda and others added 16 commits September 28, 2022 10:36
@kminoda
catch up with the modification in autoware_map_msgs
83509d3 
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@pre-commit-ci
ci(pre-commit): autofix
571a666
@kminoda
aligned with autoware_map_msgs change (differential/partial modules s…
b05e2c5 
…eperation)

Signed-off-by: kminoda <koji.minoda@tier4.jp>
@pre-commit-ci
ci(pre-commit): autofix
52fb97c
@kminoda
debugged
25fb036
@kminoda
debugged
b943ded 
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda
Merge branch 'feature/map_loader_supports_dynamic_loading' of github.…
9145857 
…com:kminoda/autoware.universe into feature/map_loader_supports_dynamic_loading
@kminoda
added min-max info and others
26bb805 
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@pre-commit-ci
ci(pre-commit): autofix
c265b64
@kminoda
minor fix
64f09f4 
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda
resolved conflict
f1484ec 
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda
already_loaded -> cached
6d6a2eb 
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@pre-commit-ci
ci(pre-commit): autofix
c7379a2
@kminoda
load_ -> get_
894e28e 
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda
Merge branch 'feature/map_loader_supports_dynamic_loading' of github.…
dca2a43 
…com:kminoda/autoware.universe into feature/map_loader_supports_dynamic_loading
@pre-commit-ci
ci(pre-commit): autofix
5c0b2f6
@kminoda kminoda mentioned this pull request Oct 20, 2022
Closed
7 tasks
@yukkysaito yukkysaito self-requested a review November 4, 2022 06:56
kminoda and others added 3 commits November 8, 2022 13:45
@kminoda
resolve pre-commit
1b66914 
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@pre-commit-ci
ci(pre-commit): autofix
d29c6d0
@kminoda
minor fix
4db3381 
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda
removed leaf_size description
3bff6ec 
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda
Merge branch 'feature/map_loader_supports_dynamic_loading' of github.…
23013a4 
…com:kminoda/autoware.universe into feature/map_loader_supports_dynamic_loading
@kminoda kminoda requested a review from a team as a code owner November 18, 2022 09:36
pre-commit-ci bot and others added 10 commits November 18, 2022 09:38
@pre-commit-ci
ci(pre-commit): autofix
d761557
@kminoda
refactor sphereAndBoxOverlapExists
0cc613e 
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda
Merge branch 'feature/map_loader_supports_dynamic_loading' of github.…
87f6bf3 
…com:kminoda/autoware.universe into feature/map_loader_supports_dynamic_loading
@pre-commit-ci
ci(pre-commit): autofix
79622a7
@kminoda
added test for sphereAndBoxOverlapExists
103cec5 
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda
Merge branch 'feature/map_loader_supports_dynamic_loading' of github.…
29a4e02 
…com:kminoda/autoware.universe into feature/map_loader_supports_dynamic_loading
@pre-commit-ci
ci(pre-commit): autofix
ca6276a
@kminoda
remove downsample function for now
805a725 
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda
remove fmt from target_link_libraries in test
5e5cf77 
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda
minor fix in cmakelists.txt
06a6071 
Signed-off-by: kminoda <koji.minoda@tier4.jp>
@kminoda
Copy link
Contributor Author

kminoda commented Nov 28, 2022

@RyuYamamoto @yukkysaito Friendly ping for your review 👀

yukkysaito
yukkysaito approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

RyuYamamoto
RyuYamamoto approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@RyuYamamoto RyuYamamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late in PR checking.

LGTM

@kminoda
Copy link
Contributor Author

kminoda commented Dec 1, 2022

@mitsudome-r @kenji-miyake Do you know why this PR cannot be merged although I got the approve from one of the maintainers (@.RyuYamamoto)?
He's also added in the CODEOWNERS file.

@kenji-miyake
Copy link
Contributor

It was due to tier4_map_launch. Added maintainers in #2416.

launch/tier4_map_launch/** ryohsuke.mitsudome@tier4.jp @autowarefoundation/autoware-global-codeowners

@kminoda kminoda merged commit 8bbc505 into autowarefoundation:main Dec 1, 2022
@tier4-autoware-public-bot tier4-autoware-public-bot bot mentioned this pull request Dec 1, 2022
Merged
@kminoda kminoda deleted the feature/map_loader_supports_dynamic_loading branch December 13, 2022 00:20
HansRobo pushed a commit to HansRobo/autoware.universe that referenced this pull request Dec 16, 2022
@kminoda @pre-commit-ci @HansRobo
feat(map_loader): add partial map loading interface in pointcloud_map…
4aafa54 
…_loader (autowarefoundation#1938)

* first commit

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* reverted unnecessary modification

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* renamed some classes

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* move autoware_map_msgs to autoware_msgs repos

Signed-off-by: kminoda <koji.m.minoda@gmail.com>

* catch up with the modification in autoware_map_msgs

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* aligned with autoware_map_msgs change (differential/partial modules seperation)

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* debugged

* debugged

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* added min-max info and others

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* minor fix

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* already_loaded -> cached

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* load_ -> get_

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* resolve pre-commit

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* minor fix

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* update readme

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* update readme

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* minor fix in readme

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* grammarly

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* ci(pre-commit): autofix

* fix copyright

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* fix launch file

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* remove leaf_size param

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* removed unnecessary things

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* removed downsample for now

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* removed differential_map_loader for this PR (would make another PR for this)

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* removed differential_map_loader, debugged

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* removed leaf_size description

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* refactor sphereAndBoxOverlapExists

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* added test for sphereAndBoxOverlapExists

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* remove downsample function for now

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* remove fmt from target_link_libraries in test

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* minor fix in cmakelists.txt

Signed-off-by: kminoda <koji.minoda@tier4.jp>

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.m.minoda@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Kotaro Yoshimoto <pythagora.yoshimoto@gmail.com>
kminoda added a commit to kminoda/autoware.universe that referenced this pull request Jan 6, 2023
@kminoda @pre-commit-ci
feat(map_loader): add partial map loading interface in pointcloud_map…
7bd6792 
…_loader (autowarefoundation#1938)

* first commit

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* reverted unnecessary modification

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* renamed some classes

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* move autoware_map_msgs to autoware_msgs repos

Signed-off-by: kminoda <koji.m.minoda@gmail.com>

* catch up with the modification in autoware_map_msgs

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* aligned with autoware_map_msgs change (differential/partial modules seperation)

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* debugged

* debugged

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* added min-max info and others

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* minor fix

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* already_loaded -> cached

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* load_ -> get_

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* resolve pre-commit

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* minor fix

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* update readme

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* update readme

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* minor fix in readme

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* grammarly

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* ci(pre-commit): autofix

* fix copyright

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* fix launch file

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* remove leaf_size param

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* removed unnecessary things

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* removed downsample for now

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* removed differential_map_loader for this PR (would make another PR for this)

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* removed differential_map_loader, debugged

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* removed leaf_size description

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* refactor sphereAndBoxOverlapExists

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* added test for sphereAndBoxOverlapExists

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* remove downsample function for now

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* remove fmt from target_link_libraries in test

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* minor fix in cmakelists.txt

Signed-off-by: kminoda <koji.minoda@tier4.jp>

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.m.minoda@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: kminoda <koji.minoda@tier4.jp>
h-ohta pushed a commit to tier4/autoware.universe that referenced this pull request Jan 26, 2023
@kminoda @pre-commit-ci @h-ohta
feat(map_loader): add partial map loading interface in pointcloud_map…
eb0f72d 
…_loader (autowarefoundation#1938)

* first commit

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* reverted unnecessary modification

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* renamed some classes

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* move autoware_map_msgs to autoware_msgs repos

Signed-off-by: kminoda <koji.m.minoda@gmail.com>

* catch up with the modification in autoware_map_msgs

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* aligned with autoware_map_msgs change (differential/partial modules seperation)

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* debugged

* debugged

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* added min-max info and others

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* minor fix

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* already_loaded -> cached

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* load_ -> get_

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* resolve pre-commit

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* minor fix

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* update readme

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* update readme

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* minor fix in readme

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* grammarly

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* ci(pre-commit): autofix

* fix copyright

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* fix launch file

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* remove leaf_size param

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* removed unnecessary things

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* removed downsample for now

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* removed differential_map_loader for this PR (would make another PR for this)

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* removed differential_map_loader, debugged

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* removed leaf_size description

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* refactor sphereAndBoxOverlapExists

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* added test for sphereAndBoxOverlapExists

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* remove downsample function for now

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* remove fmt from target_link_libraries in test

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* minor fix in cmakelists.txt

Signed-off-by: kminoda <koji.minoda@tier4.jp>

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.m.minoda@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
h-ohta pushed a commit to tier4/autoware.universe that referenced this pull request Jan 26, 2023
@kminoda @pre-commit-ci @h-ohta
feat(map_loader): add partial map loading interface in pointcloud_map…
50d92e8 
…_loader (autowarefoundation#1938)

* first commit

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* reverted unnecessary modification

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* renamed some classes

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* move autoware_map_msgs to autoware_msgs repos

Signed-off-by: kminoda <koji.m.minoda@gmail.com>

* catch up with the modification in autoware_map_msgs

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* aligned with autoware_map_msgs change (differential/partial modules seperation)

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* debugged

* debugged

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* added min-max info and others

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* minor fix

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* already_loaded -> cached

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* load_ -> get_

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* resolve pre-commit

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* minor fix

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* update readme

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* update readme

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* minor fix in readme

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* grammarly

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* ci(pre-commit): autofix

* fix copyright

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* fix launch file

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* remove leaf_size param

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* removed unnecessary things

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* removed downsample for now

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* removed differential_map_loader for this PR (would make another PR for this)

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* removed differential_map_loader, debugged

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* removed leaf_size description

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* refactor sphereAndBoxOverlapExists

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* added test for sphereAndBoxOverlapExists

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* remove downsample function for now

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* remove fmt from target_link_libraries in test

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* minor fix in cmakelists.txt

Signed-off-by: kminoda <koji.minoda@tier4.jp>

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.m.minoda@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
h-ohta pushed a commit to tier4/autoware.universe that referenced this pull request Jan 26, 2023
@kminoda @pre-commit-ci @h-ohta
feat(map_loader): add partial map loading interface in pointcloud_map…
3e7a9e7 
…_loader (autowarefoundation#1938)

* first commit

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* reverted unnecessary modification

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* renamed some classes

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* move autoware_map_msgs to autoware_msgs repos

Signed-off-by: kminoda <koji.m.minoda@gmail.com>

* catch up with the modification in autoware_map_msgs

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* aligned with autoware_map_msgs change (differential/partial modules seperation)

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* debugged

* debugged

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* added min-max info and others

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* minor fix

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* already_loaded -> cached

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* load_ -> get_

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* resolve pre-commit

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* minor fix

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* update readme

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* update readme

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* minor fix in readme

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* grammarly

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* ci(pre-commit): autofix

* fix copyright

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* fix launch file

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* remove leaf_size param

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* removed unnecessary things

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* removed downsample for now

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* removed differential_map_loader for this PR (would make another PR for this)

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* removed differential_map_loader, debugged

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* removed leaf_size description

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* refactor sphereAndBoxOverlapExists

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* added test for sphereAndBoxOverlapExists

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* remove downsample function for now

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* remove fmt from target_link_libraries in test

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* minor fix in cmakelists.txt

Signed-off-by: kminoda <koji.minoda@tier4.jp>

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.m.minoda@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
h-ohta pushed a commit to tier4/autoware.universe that referenced this pull request Jan 27, 2023
@kminoda @pre-commit-ci @h-ohta
feat(map_loader): add partial map loading interface in pointcloud_map…
a015692 
…_loader (autowarefoundation#1938)

* first commit

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* reverted unnecessary modification

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* renamed some classes

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* move autoware_map_msgs to autoware_msgs repos

Signed-off-by: kminoda <koji.m.minoda@gmail.com>

* catch up with the modification in autoware_map_msgs

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* aligned with autoware_map_msgs change (differential/partial modules seperation)

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* debugged

* debugged

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* added min-max info and others

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* minor fix

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* already_loaded -> cached

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* load_ -> get_

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* resolve pre-commit

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* minor fix

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* update readme

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* update readme

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* minor fix in readme

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* grammarly

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* ci(pre-commit): autofix

* fix copyright

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* fix launch file

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* remove leaf_size param

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* removed unnecessary things

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* removed downsample for now

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* removed differential_map_loader for this PR (would make another PR for this)

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* removed differential_map_loader, debugged

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* removed leaf_size description

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* refactor sphereAndBoxOverlapExists

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* added test for sphereAndBoxOverlapExists

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* ci(pre-commit): autofix

* remove downsample function for now

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* remove fmt from target_link_libraries in test

Signed-off-by: kminoda <koji.minoda@tier4.jp>

* minor fix in cmakelists.txt

Signed-off-by: kminoda <koji.minoda@tier4.jp>

Signed-off-by: kminoda <koji.minoda@tier4.jp>
Signed-off-by: kminoda <koji.m.minoda@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@badai-nguyen badai-nguyen mentioned this pull request Mar 16, 2023
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YamatoAndo YamatoAndo YamatoAndo left review comments

@RyuYamamoto RyuYamamoto RyuYamamoto approved these changes

@yukkysaito yukkysaito yukkysaito approved these changes

@mitsudome-r mitsudome-r Awaiting requested review from mitsudome-r

Assignees

@kminoda kminoda

Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) component:map Map creation, storage, and loading. (auto-assigned) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kminoda @xmfcx @kenji-miyake @RyuYamamoto @yukkysaito @YamatoAndo @shmpwk