fix(lidar_apollo_segmentation_tvm): always run ament_auto_package() in CMakeLists.txt #1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n CMakeLists.txt Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
| @@ -19,7 +19,8 @@ find_package(autoware_cmake REQUIRED) | |||
| autoware_package() | |||
|
|
|||
| # Check that a neural network was available for lidar_apollo_segmentation_tvm to be built. | |||
| if(lidar_apollo_segmentation_tvm_FOUND) | |||
| autoware_check_neural_network(baidu_cnn "${${lidar_apollo_segmentation_tvm}_BACKEND}") | |||
There was a problem hiding this comment.
@mitsudome-r Is there something wrong with checking if the "core" package has been found when building this one? Because that's fundamentally what we want to check here.
With this change lidar_apollo_segmentation_tvm is not a variable, so this package will probably not get built even when the correct cmake variable is set by the user.
There was a problem hiding this comment.
Oh, I see: now it is always found so that check doesn't make sense anymore.
I'll fix the behavior as part of another PR: #1880, nobody depends on this anyway so it's fine if it doesn't work for a bit.
boyali
pushed a commit
to boyali/autoware.universe
that referenced
this pull request
Oct 3, 2022
…n CMakeLists.txt (autowarefoundation#1995) Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
boyali
pushed a commit
to boyali/autoware.universe
that referenced
this pull request
Oct 3, 2022
…n CMakeLists.txt (autowarefoundation#1995) Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
boyali
pushed a commit
to boyali/autoware.universe
that referenced
this pull request
Oct 19, 2022
…n CMakeLists.txt (autowarefoundation#1995) Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp> Signed-off-by: mitsudome-r <ryohsuke.mitsudome@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #1994
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.