feat(tier4_perception_launch): add enable_fine_detection_option #1991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
yukkysaito
reviewed
Sep 30, 2022
| @@ -35,6 +35,7 @@ | |||
| /> | |||
| <arg name="use_pointcloud_container" default="false" description="launch pointcloud container"/> | |||
| <arg name="pointcloud_container_name" default="pointcloud_container"/> | |||
| <arg name="enable_fine_detection" default="true"/> | |||
There was a problem hiding this comment.
How about this?
Suggested change
| <arg name="enable_fine_detection" default="true"/> | |
| <!-- Traffic Light Recognition Parameters --> | |
| <arg name="traffic_light_recognition/enable_fine_detection" default="true"/> |
There was a problem hiding this comment.
Seems nice!
I commited it by c803812.
7 tasks
Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp>
Codecov ReportBase: 10.34% // Head: 10.34% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1991 +/- ##
=======================================
Coverage 10.34% 10.34%
=======================================
Files 1162 1162
Lines 82744 82744
Branches 19280 19280
=======================================
Hits 8559 8559
Misses 64925 64925
Partials 9260 9260
*This pull request uses carry forward flags. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
8 tasks
boyali
pushed a commit
to boyali/autoware.universe
that referenced
this pull request
Oct 3, 2022
…warefoundation#1991) * feat(tier4_perception_launch): add enable_fine_detection_option Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> * chore: rename Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> * ci(pre-commit): autofix Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali
pushed a commit
to boyali/autoware.universe
that referenced
this pull request
Oct 3, 2022
…warefoundation#1991) * feat(tier4_perception_launch): add enable_fine_detection_option Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> * chore: rename Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> * ci(pre-commit): autofix Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
boyali
pushed a commit
to boyali/autoware.universe
that referenced
this pull request
Oct 19, 2022
…warefoundation#1991) * feat(tier4_perception_launch): add enable_fine_detection_option Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> * chore: rename Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> * ci(pre-commit): autofix Signed-off-by: Shumpei Wakabayashi <shumpei.wakabayashi@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shumpei Wakabayashi shumpei.wakabayashi@tier4.jp
Description
Add
enable_fine_detectionoption for perception launcher.The current trained model of fine detection is finetuned with the real environment. Thus it is difficult to adapt the simulation environment now. If we reproduce perception module in the degital twin simulation environment for example, we should set
enable_fine_detection:=false.This is needed with the new degital twin launcher.
Related links
autowarefoundation/autoware_launch#98
Tests performed
I tested this launcher with TIERIV INTERNAL DEGITAL TWIN SIMULATOR and it works as we expected.
Notes for reviewers
None
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.