Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rtc_interface): fix name space #1976

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

rej55
Copy link
Contributor

@rej55 rej55 commented Sep 28, 2022

Signed-off-by: Fumiya Watanabe rej55.g@gmail.com

Description

Before this change, no_stopping_area does not send RTC status because of the limitation of the character of name space.
In this PR, I change the name space of RTC status and commands.

Before:

/planning/scenario_planning/lane_driving/behavior_planning/behavior_**_planner/**/cooperate_status
/planning/scenario_planning/lane_driving/behavior_planning/behavior_**_planner/**/cooperate_commands

After:

/planning/cooperate_status/**
/planning/cooperate_commands/**

Change for api is following.
tier4/tier4_ad_api_adaptor#61

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Base: 10.34% // Head: 10.02% // Decreases project coverage by -0.32% ⚠️

Coverage data is based on head (15f2d42) compared to base (a63ed16).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1976      +/-   ##
==========================================
- Coverage   10.34%   10.02%   -0.33%     
==========================================
  Files        1146     1155       +9     
  Lines       81464    84110    +2646     
  Branches    19003    20783    +1780     
==========================================
+ Hits         8429     8433       +4     
- Misses      63915    66351    +2436     
- Partials     9120     9326     +206     
Flag Coverage Δ *Carryforward flag
differential 2.69% <0.00%> (?)
total 10.32% <0.00%> (ø) Carriedforward from a63ed16

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
planning/rtc_interface/src/rtc_interface.cpp 0.00% <0.00%> (ø)
...lanner/include/behavior_path_planner/utilities.hpp 22.85% <0.00%> (-2.15%) ⬇️
planning/behavior_path_planner/src/utilities.cpp 2.85% <0.00%> (-0.29%) ⬇️
.../behavior_path_planner/src/turn_signal_decider.cpp 0.00% <0.00%> (ø)
...ehavior_path_planner/src/behavior_tree_manager.cpp 0.00% <0.00%> (ø)
...r_path_planner/src/scene_module/pull_over/util.cpp 0.00% <0.00%> (ø)
...path_planner/src/scene_module/lane_change/util.cpp 0.00% <0.00%> (ø)
...ath_planner/src/scene_module/lane_change/debug.cpp 0.00% <0.00%> (ø)
...elocity_planner/src/scene_module/run_out/scene.cpp 0.00% <0.00%> (ø)
...th_planner/src/scene_module/utils/path_shifter.cpp 0.00% <0.00%> (ø)
... and 29 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tkimura4
Copy link
Contributor

cc. @0x126

Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
(This PR is not merge-ready now because tier4/tier4_ad_api_adaptor#61 has not been reviewed yet)

@rej55 rej55 merged commit e615a72 into autowarefoundation:main Sep 29, 2022
@rej55 rej55 deleted the fix/rtc_name_space branch September 29, 2022 03:58
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>

Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants