-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rtc_interface): fix name space #1976
Conversation
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Codecov ReportBase: 10.34% // Head: 10.02% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1976 +/- ##
==========================================
- Coverage 10.34% 10.02% -0.33%
==========================================
Files 1146 1155 +9
Lines 81464 84110 +2646
Branches 19003 20783 +1780
==========================================
+ Hits 8429 8433 +4
- Misses 63915 66351 +2436
- Partials 9120 9326 +206
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
cc. @0x126 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(This PR is not merge-ready now because tier4/tier4_ad_api_adaptor#61 has not been reviewed yet)
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com> Signed-off-by: Fumiya Watanabe <rej55.g@gmail.com>
Signed-off-by: Fumiya Watanabe rej55.g@gmail.com
Description
Before this change, no_stopping_area does not send RTC status because of the limitation of the character of name space.
In this PR, I change the name space of RTC status and commands.
Before:
After:
Change for api is following.
tier4/tier4_ad_api_adaptor#61
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.