-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tier4_autoware_utils): fix covariance enum name #1950
fix(tier4_autoware_utils): fix covariance enum name #1950
Conversation
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Codecov ReportBase: 10.28% // Head: 10.17% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1950 +/- ##
==========================================
- Coverage 10.28% 10.17% -0.12%
==========================================
Files 1147 1148 +1
Lines 81963 83571 +1608
Branches 19035 20133 +1098
==========================================
+ Hits 8433 8503 +70
- Misses 64409 65766 +1357
- Partials 9121 9302 +181
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
...cks_msgs_converter/src/radar_tracks_msgs_converter_node/radar_tracks_msgs_converter_node.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: scepter914 <scepter914@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks clean! Thanks.
Signed-off-by: scepter914 <scepter914@gmail.com>
…on#1950) * fix(tier4_autoware_utils): change XYZRPY covariance enum name Signed-off-by: scepter914 <scepter914@gmail.com> * fix comment Signed-off-by: scepter914 <scepter914@gmail.com> * fix covariance index Signed-off-by: scepter914 <scepter914@gmail.com> * fix covariance index Signed-off-by: scepter914 <scepter914@gmail.com> * fix typo Signed-off-by: scepter914 <scepter914@gmail.com> * fix covariance variable name Signed-off-by: scepter914 <scepter914@gmail.com> Signed-off-by: scepter914 <scepter914@gmail.com>
…util (#1917) * refactor(ekf_localizer): use covariance index util of tier4_autoware_util Signed-off-by: scepter914 <scepter914@gmail.com> * fix alias from #1950 Signed-off-by: scepter914 <scepter914@gmail.com> * fix covariance Signed-off-by: scepter914 <scepter914@gmail.com> Signed-off-by: scepter914 <scepter914@gmail.com>
…on#1950) * fix(tier4_autoware_utils): change XYZRPY covariance enum name Signed-off-by: scepter914 <scepter914@gmail.com> * fix comment Signed-off-by: scepter914 <scepter914@gmail.com> * fix covariance index Signed-off-by: scepter914 <scepter914@gmail.com> * fix covariance index Signed-off-by: scepter914 <scepter914@gmail.com> * fix typo Signed-off-by: scepter914 <scepter914@gmail.com> * fix covariance variable name Signed-off-by: scepter914 <scepter914@gmail.com> Signed-off-by: scepter914 <scepter914@gmail.com>
…on#1950) * fix(tier4_autoware_utils): change XYZRPY covariance enum name Signed-off-by: scepter914 <scepter914@gmail.com> * fix comment Signed-off-by: scepter914 <scepter914@gmail.com> * fix covariance index Signed-off-by: scepter914 <scepter914@gmail.com> * fix covariance index Signed-off-by: scepter914 <scepter914@gmail.com> * fix typo Signed-off-by: scepter914 <scepter914@gmail.com> * fix covariance variable name Signed-off-by: scepter914 <scepter914@gmail.com> Signed-off-by: scepter914 <scepter914@gmail.com>
…util (autowarefoundation#1917) * refactor(ekf_localizer): use covariance index util of tier4_autoware_util Signed-off-by: scepter914 <scepter914@gmail.com> * fix alias from autowarefoundation#1950 Signed-off-by: scepter914 <scepter914@gmail.com> * fix covariance Signed-off-by: scepter914 <scepter914@gmail.com> Signed-off-by: scepter914 <scepter914@gmail.com>
…on#1950) * fix(tier4_autoware_utils): change XYZRPY covariance enum name Signed-off-by: scepter914 <scepter914@gmail.com> * fix comment Signed-off-by: scepter914 <scepter914@gmail.com> * fix covariance index Signed-off-by: scepter914 <scepter914@gmail.com> * fix covariance index Signed-off-by: scepter914 <scepter914@gmail.com> * fix typo Signed-off-by: scepter914 <scepter914@gmail.com> * fix covariance variable name Signed-off-by: scepter914 <scepter914@gmail.com> Signed-off-by: scepter914 <scepter914@gmail.com>
…util (autowarefoundation#1917) * refactor(ekf_localizer): use covariance index util of tier4_autoware_util Signed-off-by: scepter914 <scepter914@gmail.com> * fix alias from autowarefoundation#1950 Signed-off-by: scepter914 <scepter914@gmail.com> * fix covariance Signed-off-by: scepter914 <scepter914@gmail.com> Signed-off-by: scepter914 <scepter914@gmail.com>
…on#1950) * fix(tier4_autoware_utils): change XYZRPY covariance enum name Signed-off-by: scepter914 <scepter914@gmail.com> * fix comment Signed-off-by: scepter914 <scepter914@gmail.com> * fix covariance index Signed-off-by: scepter914 <scepter914@gmail.com> * fix covariance index Signed-off-by: scepter914 <scepter914@gmail.com> * fix typo Signed-off-by: scepter914 <scepter914@gmail.com> * fix covariance variable name Signed-off-by: scepter914 <scepter914@gmail.com> Signed-off-by: scepter914 <scepter914@gmail.com>
…util (autowarefoundation#1917) * refactor(ekf_localizer): use covariance index util of tier4_autoware_util Signed-off-by: scepter914 <scepter914@gmail.com> * fix alias from autowarefoundation#1950 Signed-off-by: scepter914 <scepter914@gmail.com> * fix covariance Signed-off-by: scepter914 <scepter914@gmail.com> Signed-off-by: scepter914 <scepter914@gmail.com>
Description
This PR change from pose_covariance_index::POSE_COV_IDX to xyzrpy_covariance_index::XYZRPY_COV_IDX.
This change of util library may make easy to read.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.