Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tier4_autoware_utils): fix covariance enum name #1950

Merged
merged 6 commits into from
Sep 27, 2022

Conversation

scepter914
Copy link
Contributor

@scepter914 scepter914 commented Sep 25, 2022

Description

This PR change from pose_covariance_index::POSE_COV_IDX to xyzrpy_covariance_index::XYZRPY_COV_IDX.
This change of util library may make easy to read.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
Signed-off-by: scepter914 <scepter914@gmail.com>
@scepter914 scepter914 requested a review from miursh September 25, 2022 23:30
@scepter914 scepter914 changed the title Fix/covariance util fix(tier4_autoware_utils): change XYZRPY covariance enum name Sep 25, 2022
@scepter914 scepter914 changed the title fix(tier4_autoware_utils): change XYZRPY covariance enum name fix(tier4_autoware_utils):change XYZRPY covariance enum name Sep 25, 2022
@scepter914 scepter914 changed the title fix(tier4_autoware_utils):change XYZRPY covariance enum name fix(tier4_autoware_utils): fix covariance enum name Sep 25, 2022
@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Base: 10.28% // Head: 10.17% // Decreases project coverage by -0.11% ⚠️

Coverage data is based on head (d2d66d3) compared to base (f1aaa5d).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1950      +/-   ##
==========================================
- Coverage   10.28%   10.17%   -0.12%     
==========================================
  Files        1147     1148       +1     
  Lines       81963    83571    +1608     
  Branches    19035    20133    +1098     
==========================================
+ Hits         8433     8503      +70     
- Misses      64409    65766    +1357     
- Partials     9121     9302     +181     
Flag Coverage Δ *Carryforward flag
differential 11.55% <0.00%> (?)
total 10.27% <0.00%> (ø) Carriedforward from 4c8c9b2

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ted_object/src/radar_fusion_to_detected_object.cpp 0.00% <ø> (ø)
...onverter_node/radar_tracks_msgs_converter_node.cpp 0.00% <0.00%> (ø)
.../behavior_path_planner/src/turn_signal_decider.cpp 0.00% <0.00%> (ø)
...ehavior_path_planner/src/behavior_tree_manager.cpp 0.00% <0.00%> (ø)
...th_planner/src/scene_module/utils/path_shifter.cpp 0.00% <0.00%> (ø)
...anner/src/scene_module/pull_out/shift_pull_out.cpp 0.00% <0.00%> (ø)
...nner/src/scene_module/pull_out/pull_out_module.cpp 0.00% <0.00%> (ø)
...er/src/scene_module/avoidance/avoidance_module.cpp 0.00% <0.00%> (ø)
...er/src/scene_module/pull_over/pull_over_module.cpp 0.00% <0.00%> (ø)
...rc/scene_module/lane_change/lane_change_module.cpp 0.00% <0.00%> (ø)
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: scepter914 <scepter914@gmail.com>
@scepter914 scepter914 changed the title fix(tier4_autoware_utils): fix covariance enum name fix(tier4_autoware_utils):fix covariance enum name Sep 26, 2022
@scepter914 scepter914 changed the title fix(tier4_autoware_utils):fix covariance enum name fix(tier4_autoware_utils):fix covariance enum name Sep 26, 2022
@scepter914 scepter914 changed the title fix(tier4_autoware_utils):fix covariance enum name fix(tier4_autoware_utils): fix covariance enum name Sep 26, 2022
Copy link
Contributor

@kenji-miyake kenji-miyake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean! Thanks.

@scepter914 scepter914 merged commit 51af89c into autowarefoundation:main Sep 27, 2022
@scepter914 scepter914 deleted the fix/covariance_util branch September 27, 2022 02:05
scepter914 added a commit to scepter914/autoware.universe that referenced this pull request Sep 27, 2022
Signed-off-by: scepter914 <scepter914@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…on#1950)

* fix(tier4_autoware_utils): change XYZRPY covariance enum name

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix comment

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix covariance index

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix covariance index

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix typo

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix covariance variable name

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
scepter914 added a commit that referenced this pull request Sep 29, 2022
…util (#1917)

* refactor(ekf_localizer): use covariance index util of tier4_autoware_util

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix alias  from #1950

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix covariance

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Sep 29, 2022
…on#1950)

* fix(tier4_autoware_utils): change XYZRPY covariance enum name

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix comment

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix covariance index

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix covariance index

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix typo

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix covariance variable name

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…on#1950)

* fix(tier4_autoware_utils): change XYZRPY covariance enum name

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix comment

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix covariance index

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix covariance index

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix typo

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix covariance variable name

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…util (autowarefoundation#1917)

* refactor(ekf_localizer): use covariance index util of tier4_autoware_util

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix alias  from autowarefoundation#1950

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix covariance

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…on#1950)

* fix(tier4_autoware_utils): change XYZRPY covariance enum name

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix comment

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix covariance index

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix covariance index

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix typo

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix covariance variable name

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…util (autowarefoundation#1917)

* refactor(ekf_localizer): use covariance index util of tier4_autoware_util

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix alias  from autowarefoundation#1950

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix covariance

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…on#1950)

* fix(tier4_autoware_utils): change XYZRPY covariance enum name

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix comment

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix covariance index

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix covariance index

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix typo

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix covariance variable name

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…util (autowarefoundation#1917)

* refactor(ekf_localizer): use covariance index util of tier4_autoware_util

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix alias  from autowarefoundation#1950

Signed-off-by: scepter914 <scepter914@gmail.com>

* fix covariance

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants