Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(perception_util): add maintainer #1920

Conversation

scepter914
Copy link
Contributor

@scepter914 scepter914 commented Sep 21, 2022

Signed-off-by: scepter914 scepter914@gmail.com

Description

Add maintainer to perception_util

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: scepter914 <scepter914@gmail.com>
Copy link
Contributor

@takayuki5168 takayuki5168 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Base: 10.37% // Head: 10.47% // Increases project coverage by +0.10% 🎉

Coverage data is based on head (a2dda01) compared to base (478c759).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1920      +/-   ##
==========================================
+ Coverage   10.37%   10.47%   +0.10%     
==========================================
  Files        1147     1146       -1     
  Lines       81324    77873    -3451     
  Branches    19048    18799     -249     
==========================================
- Hits         8434     8155     -279     
+ Misses      63895    60883    -3012     
+ Partials     8995     8835     -160     
Flag Coverage Δ *Carryforward flag
differential 6.60% <ø> (?)
total 10.44% <ø> (+0.09%) ⬆️ Carriedforward from 478c759

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...ssing/include/signal_processing/lowpass_filter.hpp 33.33% <0.00%> (-66.67%) ⬇️
...auto_common/include/helper_functions/type_name.hpp 66.66% <0.00%> (-33.34%) ⬇️
..._utils/include/grid_map_utils/polygon_iterator.hpp 50.00% <0.00%> (-25.00%) ⬇️
...or/include/planning_error_monitor/debug_marker.hpp 50.00% <0.00%> (-25.00%) ⬇️
...oware_auto_geometry/test/src/test_hull_pockets.cpp 45.65% <0.00%> (-10.60%) ⬇️
...autoware_auto_geometry/test/src/test_common_2d.cpp 42.85% <0.00%> (-10.48%) ⬇️
...vehicle_model/sim_model_ideal_steer_acc_geared.cpp 73.58% <0.00%> (-9.44%) ⬇️
...ion/include/fault_injection/diagnostic_storage.hpp 53.84% <0.00%> (-7.70%) ⬇️
...lude/motion_utils/trajectory/path_with_lane_id.hpp 66.66% <0.00%> (-7.41%) ⬇️
common/motion_testing/test/trajectory_checks.cpp 20.00% <0.00%> (-7.28%) ⬇️
... and 517 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@scepter914 scepter914 merged commit 643645a into autowarefoundation:main Sep 22, 2022
@scepter914 scepter914 deleted the chore/perception_util_maintainer branch September 22, 2022 07:50
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
kminoda pushed a commit to kminoda/autoware.universe that referenced this pull request Sep 29, 2022
Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
1222-takeshi pushed a commit to tier4/autoware.universe that referenced this pull request Oct 7, 2022
Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants