Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(radar_tracks_msgs_converter): refactor to use covariance index library in tier4_autoware_util #1883

Conversation

scepter914
Copy link
Contributor

@scepter914 scepter914 commented Sep 15, 2022

Signed-off-by: scepter914 scepter914@gmail.com

Description

I missed refactoring twist covariance and acceleration covariance in #1849.
So I fixed these and change into util library.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…ex library in tier4_autoware_util

Signed-off-by: scepter914 <scepter914@gmail.com>
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Base: 10.35% // Head: 10.43% // Increases project coverage by +0.07% 🎉

Coverage data is based on head (56698e6) compared to base (23e261c).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1883      +/-   ##
==========================================
+ Coverage   10.35%   10.43%   +0.07%     
==========================================
  Files        1159     1233      +74     
  Lines       76307    87977   +11670     
  Branches    18788    20443    +1655     
==========================================
+ Hits         7905     9179    +1274     
- Misses      59482    69340    +9858     
- Partials     8920     9458     +538     
Flag Coverage Δ *Carryforward flag
differential 0.00% <0.00%> (?)
total 10.42% <0.00%> (+0.06%) ⬆️ Carriedforward from 7e2370d

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...onverter_node/radar_tracks_msgs_converter_node.cpp 0.00% <0.00%> (ø)
...lude/freespace_planning_algorithms/reeds_shepp.hpp 50.00% <0.00%> (-50.00%) ⬇️
...tic_evaluator/include/kinematic_evaluator/stat.hpp 62.50% <0.00%> (-19.32%) ⬇️
..._evaluator/include/localization_evaluator/stat.hpp 56.25% <0.00%> (-16.48%) ⬇️
.../src/vehicle/test_vehicle_state_checker_helper.hpp 70.58% <0.00%> (-9.42%) ⬇️
planning/behavior_path_planner/test/input.cpp 60.00% <0.00%> (-7.86%) ⬇️
...city_planner/include/utilization/state_machine.hpp 31.03% <0.00%> (-7.07%) ⬇️
common/perception_utils/src/perception_utils.cpp 56.75% <0.00%> (-6.88%) ⬇️
...include/motion_utils/trajectory/tmp_conversion.hpp 60.00% <0.00%> (-6.67%) ⬇️
...oware_auto_geometry/include/geometry/common_2d.hpp 82.66% <0.00%> (-5.91%) ⬇️
... and 851 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@scepter914 scepter914 merged commit fc48913 into autowarefoundation:main Sep 16, 2022
@scepter914 scepter914 deleted the refactor/radar_converter_covariance branch September 16, 2022 01:20
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…ex library in tier4_autoware_util (autowarefoundation#1883)

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…ex library in tier4_autoware_util (autowarefoundation#1883)

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…ex library in tier4_autoware_util (autowarefoundation#1883)

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…ex library in tier4_autoware_util (autowarefoundation#1883)

Signed-off-by: scepter914 <scepter914@gmail.com>

Signed-off-by: scepter914 <scepter914@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants