-
Notifications
You must be signed in to change notification settings - Fork 683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ekf_localizer): isolate mahalanobis functions and add tests #1877
Conversation
Codecov ReportBase: 10.43% // Head: 10.41% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1877 +/- ##
==========================================
- Coverage 10.43% 10.41% -0.02%
==========================================
Files 1232 1235 +3
Lines 87941 88144 +203
Branches 20428 20592 +164
==========================================
+ Hits 9174 9181 +7
- Misses 69433 69600 +167
- Partials 9334 9363 +29
*This pull request uses carry forward flags. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(A DEBUG_INFO log defined in the mahalanobisGate
function in original code is going to be deleted with this PR, but I think it won't be a big problem)
…utowarefoundation#1877) * refactor(ekf_localizer): isolate mahalanobis functions and add tests
…utowarefoundation#1877) * refactor(ekf_localizer): isolate mahalanobis functions and add tests
…utowarefoundation#1877) * refactor(ekf_localizer): isolate mahalanobis functions and add tests
…utowarefoundation#1877) * refactor(ekf_localizer): isolate mahalanobis functions and add tests
Description
Related links
Tests performed
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.