Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ekf_localizer): isolate mahalanobis functions and add tests #1877

Merged
merged 2 commits into from
Sep 16, 2022

Conversation

IshitaTakeshi
Copy link
Contributor

@IshitaTakeshi IshitaTakeshi commented Sep 15, 2022

Description

  • Isolate the Mahalanobis gate function
  • Add a function to compute the squared Mahalanobis distance
  • Add unit tests

Related links

Tests performed

  • Validate the squared Mahalanobis distance
  • Validate the gate condition around the boundary value

Notes for reviewers

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Base: 10.43% // Head: 10.41% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (3934da4) compared to base (ce3ecfb).
Patch coverage: 14.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1877      +/-   ##
==========================================
- Coverage   10.43%   10.41%   -0.02%     
==========================================
  Files        1232     1235       +3     
  Lines       87941    88144     +203     
  Branches    20428    20592     +164     
==========================================
+ Hits         9174     9181       +7     
- Misses      69433    69600     +167     
- Partials     9334     9363      +29     
Flag Coverage Δ *Carryforward flag
differential 18.52% <17.50%> (?)
total 10.41% <0.00%> (ø) Carriedforward from ce3ecfb

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
..._localizer/include/ekf_localizer/ekf_localizer.hpp 0.00% <ø> (ø)
...on/ekf_localizer/include/ekf_localizer/warning.hpp 0.00% <0.00%> (ø)
localization/ekf_localizer/src/ekf_localizer.cpp 0.00% <0.00%> (ø)
...calization/ekf_localizer/test/test_mahalanobis.cpp 44.44% <44.44%> (ø)
localization/ekf_localizer/src/mahalanobis.cpp 60.00% <60.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
(A DEBUG_INFO log defined in the mahalanobisGate function in original code is going to be deleted with this PR, but I think it won't be a big problem)

@IshitaTakeshi IshitaTakeshi merged commit ace1ce7 into main Sep 16, 2022
@IshitaTakeshi IshitaTakeshi deleted the refactor/isolate-mahalanobis branch September 16, 2022 04:44
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Sep 28, 2022
…utowarefoundation#1877)

* refactor(ekf_localizer): isolate mahalanobis functions and add tests
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…utowarefoundation#1877)

* refactor(ekf_localizer): isolate mahalanobis functions and add tests
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 3, 2022
…utowarefoundation#1877)

* refactor(ekf_localizer): isolate mahalanobis functions and add tests
boyali pushed a commit to boyali/autoware.universe that referenced this pull request Oct 19, 2022
…utowarefoundation#1877)

* refactor(ekf_localizer): isolate mahalanobis functions and add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants